Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve message context items when SetMessage is called #534

Merged
merged 1 commit into from
Mar 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/KafkaFlow/MessageContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,25 @@ public MessageContext(
IConsumerContext consumer,
IProducerContext producer,
IReadOnlyCollection<string> brokers)
: this(message, headers, dependencyResolver, consumer, producer, brokers, new Dictionary<string, object>())
{
}

private MessageContext(
Message message,
IMessageHeaders headers,
IDependencyResolver dependencyResolver,
IConsumerContext consumer,
IProducerContext producer,
IReadOnlyCollection<string> brokers,
IDictionary<string, object> items)
{
this.Message = message;
this.DependencyResolver = dependencyResolver;
this.Headers = headers ?? new MessageHeaders();
this.ConsumerContext = consumer;
this.ProducerContext = producer;
this.Items = new Dictionary<string, object>();
this.Items = items;
this.Brokers = brokers;
}

Expand All @@ -41,5 +53,6 @@ public MessageContext(
this.DependencyResolver,
this.ConsumerContext,
this.ProducerContext,
this.Brokers);
this.Brokers,
this.Items);
}
39 changes: 39 additions & 0 deletions tests/KafkaFlow.UnitTests/MessageContextTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
using System.Collections.Generic;
using KafkaFlow.Consumers;
using KafkaFlow.Producers;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Moq;

namespace KafkaFlow.UnitTests;

[TestClass]
public class MessageContextTests
{
[TestMethod]
public void SetMessage_ShouldSetMessageCorrectly()
{
// Arrange
var messageContext = new MessageContext(
new Message("key", "value"),
Mock.Of<IMessageHeaders>(),
Mock.Of<IDependencyResolver>(),
Mock.Of<IConsumerContext>(),
Mock.Of<IProducerContext>(),
Mock.Of<IReadOnlyCollection<string>>()
);


// Act
var changedMessage = messageContext.SetMessage("changed-key", "changed-value");

// Assert
Assert.AreEqual("changed-key", changedMessage.Message.Key);
Assert.AreEqual("changed-value", changedMessage.Message.Value);
Assert.AreSame(messageContext.ConsumerContext, changedMessage.ConsumerContext);
Assert.AreSame(messageContext.DependencyResolver, changedMessage.DependencyResolver);
Assert.AreSame(messageContext.Headers, changedMessage.Headers);
Assert.AreSame(messageContext.ProducerContext, changedMessage.ProducerContext);
Assert.AreSame(messageContext.Brokers, changedMessage.Brokers);
Assert.AreSame(messageContext.Items, changedMessage.Items);
}
}
Loading