FW-5212 Add fix for join request approval as language admin #195

NolanVH · 2023-11-20T20:30:30Z

Description of Changes

This change fixes the bug with join request approval as language admin. Note that this is a temporary fix and the permanent fix will be added in FW-5218 when the constants and display values are separated.

Checklist

~~README / documentation has been updated if needed~~
PR title / commit messages contain Jira ticket number if applicable
~~Tests have been updated / created if applicable~~

Reviewers Should Do The Following:

Review the changes here
Pull the branch and test locally

Additional Notes

N/A

sahil97 · 2023-11-21T23:58:12Z

src/components/DashboardJoinCard/DashboardJoinCardPresentation.js

@@ -65,7 +65,9 @@ function DashboardJoinCardPresentation({
              <select
                id="role-to-assign"
                name="role-to-assign"
-                onChange={(e) => setSelectedRole(e.target.value)}
+                onChange={(e) =>
+                  setSelectedRole(e.target.value.split(' ').join('_'))


Looks good for now.
In the long term we should be moving towards the discussed solution of having a mapping of displayable values and BE expected keys.