Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW-5212 Add fix for join request approval as language admin #195

Merged
merged 2 commits into from
Nov 22, 2023
Merged

FW-5212 Add fix for join request approval as language admin #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84278b6
FW-5212 Add fix for join request approval as language admin
NolanVH Nov 20, 2023
a9560c5
Merge branch 'main' into FW-5212-language-admin-join-request-approval…
NolanVH Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/DashboardJoinCard/DashboardJoinCardPresentation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ function DashboardJoinCardPresentation({
<select
id="role-to-assign"
name="role-to-assign"
onChange={(e) => setSelectedRole(e.target.value)}
onChange={(e) =>
setSelectedRole(e.target.value.split(' ').join('_'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now.
In the long term we should be moving towards the discussed solution of having a mapping of displayable values and BE expected keys.

}
className="inline-flex rounded-lg py-1.5 text-sm text-primary border border-primary shadow-sm hover:bg-gray-50"
>
<option value={MEMBER}>Approve as Member</option>
Expand Down
Loading