Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FW-6190 media selector bug #647

Merged
merged 9 commits into from
Oct 23, 2024
Merged

FW-6190 media selector bug #647

merged 9 commits into from
Oct 23, 2024

Conversation

gmcauliffe
Copy link
Contributor

@gmcauliffe gmcauliffe commented Oct 23, 2024 •
edited
Loading

Description of Changes

Please briefly explain the changes here.

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

@gmcauliffe gmcauliffe marked this pull request as ready for review October 23, 2024 17:33
@gmcauliffe
Copy link
Contributor Author

This PR is failing the "Duplication on New Code" check but actually reduces duplication in the code overall.

@gmcauliffe gmcauliffe requested a review from sahil97 October 23, 2024 17:58
sahil97
sahil97 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@sahil97 sahil97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for the refactor.
Not sure but Sonar might fail our main branch as well for duplication if the overall duplication goes higher than the threshold, but we can probably create a ticket for that and fix it next.

@sahil97 sahil97 mentioned this pull request Oct 23, 2024
Closed
2 tasks
@gmcauliffe gmcauliffe merged commit 46a21b7 into dev Oct 23, 2024
7 of 8 checks passed
@gmcauliffe gmcauliffe deleted the FW-6190-media-selector-bug branch October 23, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahfirstvoices sarahfirstvoices sarahfirstvoices approved these changes

@sahil97 sahil97 sahil97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmcauliffe @sahil97 @sarahfirstvoices