Register unity without config file #286
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| namespace NewPlatform.Flexberry.ORM.ODataService.Tests | ||
| { | ||
| using ICSSoft.STORMNET.Business; | ||
| using ICSSoft.STORMNET.Business.Audit; | ||
| using ICSSoft.STORMNET.Business.Interfaces; | ||
| using ICSSoft.STORMNET.Security; | ||
| using Microsoft.AspNetCore.Http; | ||
| using NewPlatform.Flexberry.Caching; | ||
| using NewPlatform.Flexberry.ORM.CurrentUserService; | ||
| using NewPlatform.Flexberry.ORM.ODataService.Tests.CRUD.Read.Excel; | ||
| using NewPlatform.Flexberry.ORM.ODataService.Tests.Http; | ||
| using NewPlatform.Flexberry.Reports.ExportToExcel; | ||
| using NewPlatform.Flexberry.Security; | ||
| using System.Web; | ||
| using Unity; | ||
| using Unity.Injection; | ||
|
|
||
| /// <summary> | ||
| /// This static class is designed to register dependencies in the Unity container. | ||
|
There was a problem hiding this comment. Мне кажется, что в комментариях нужно сделать акцент, что это просто вспомогательный класс для тестов. Также добавь в комментарии, что при удалении UnityConfigResolver для версии под дотнет 4.5 нужно определить нужность данного класса (пока что перерегистрировать нужно именно из-за него). Также упоминание "UnityConfigResolver" требуется, чтобы при удалении этого класса поиском наткнулись на это примечание. |
||
| /// Created to eliminate code duplication for different dotnet versions. | ||
| /// </summary> | ||
| public static class UnityContainerRegistrations | ||
| { | ||
| /// <summary> | ||
| /// Method for base dependencies registration into Unity container. | ||
| /// </summary> | ||
| /// <param name="unityContainer">Unity container.</param> | ||
| public static void Registration(IUnityContainer unityContainer) | ||
|
There was a problem hiding this comment. Пожалуй, стоит ещё отметить, какой код можно сделать только кодом, а какой и кодом и конфигом. Например, сначала тот, что и там и там, отметив комментарием. А потом тот, что только кодом теперь. |
||
| { | ||
| unityContainer.RegisterType<IHttpContextAccessor, HttpContextAccessor>(); | ||
| #if NETFRAMEWORK | ||
| unityContainer.RegisterType<ICurrentUser, WebHttpUser>( | ||
| new InjectionConstructor(unityContainer.Resolve<IHttpContextAccessor>())); | ||
| #endif | ||
| #if NETCOREAPP | ||
| unityContainer.RegisterType<ICurrentUser, WebHttpUser>(); | ||
| #endif | ||
| unityContainer.RegisterType<IAuditService, AuditService>( | ||
| new InjectionConstructor(unityContainer.Resolve<ICurrentUser>())); | ||
|
|
||
| unityContainer.RegisterSingleton<IExportService, ExportExcelODataService>("Export"); | ||
|
There was a problem hiding this comment. Разве это не регистрация изначально закомментированного кода? " |
||
| unityContainer.RegisterSingleton<IODataExportService, ExportExcel>(); | ||
| unityContainer.RegisterSingleton<ISpreadsheetCustomizer, SpreadsheetCustomizer>(); | ||
|
|
||
| unityContainer.RegisterSingleton<IConfigResolver, ConfigResolver>(); | ||
|
|
||
| unityContainer.RegisterSingleton<ICacheService, MemoryCacheService>( | ||
| new InjectionConstructor("defaultCacheForApplication", 3600)); | ||
|
|
||
| unityContainer.RegisterSingleton<ISecurityManager, EmptySecurityManager>("securityManagerWithoutRightsCheck"); | ||
|
|
||
| unityContainer.RegisterSingleton<IDataService, MSSQLDataService>( | ||
| "dataServiceForAuditAgentManagerAdapter", | ||
| new InjectionConstructor( | ||
| unityContainer.Resolve<ISecurityManager>("securityManagerWithoutRightsCheck"), | ||
| unityContainer.Resolve<IAuditService>(), | ||
| unityContainer.Resolve<IBusinessServerProvider>()), | ||
| new InjectionProperty(nameof(MSSQLDataService.CustomizationStringName), "DefConnStr")); | ||
|
|
||
| unityContainer.RegisterType<IDataService, MSSQLDataService>( | ||
| "dataServiceForSecurityManager", | ||
| new InjectionConstructor( | ||
| unityContainer.Resolve<ISecurityManager>("securityManagerWithoutRightsCheck"), | ||
| unityContainer.Resolve<IAuditService>(), | ||
| unityContainer.Resolve<IBusinessServerProvider>()), | ||
| Inject.Property(nameof(MSSQLDataService.CustomizationStringName), "DefConnStr")); | ||
|
|
||
| unityContainer.RegisterSingleton<ICacheService, MemoryCacheService>( | ||
| "cacheServiceForSecurityManager", | ||
| new InjectionConstructor("cacheForSecurityManager")); | ||
|
|
||
| unityContainer.RegisterSingleton<ICacheService, MemoryCacheService>( | ||
| "cacheServiceForAgentManager", new InjectionConstructor("cacheForAgentManager")); | ||
|
|
||
| unityContainer.RegisterSingleton<ISecurityManager, SecurityManager>( | ||
| new InjectionConstructor( | ||
| unityContainer.Resolve<IDataService>("dataServiceForSecurityManager"), | ||
| unityContainer.Resolve<ICacheService>("cacheServiceForSecurityManager"))); | ||
|
|
||
| unityContainer.RegisterSingleton<IAgentManager, AgentManager>( | ||
| new InjectionConstructor( | ||
| unityContainer.Resolve<IDataService>("dataServiceForSecurityManager"), | ||
| unityContainer.Resolve<ICacheService>("cacheServiceForSecurityManager"))); | ||
|
|
||
| unityContainer.RegisterSingleton<IPasswordHasher, Sha1PasswordHasher>(); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Для чего здесь юзинги добавлены?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed