Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always return new instance #211

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Always return new instance #211

merged 1 commit into from
Aug 8, 2023

Conversation

gksander
Copy link
Contributor

@gksander gksander commented Aug 4, 2023

Addresses #204, returns new class instance from each of the builder methods.

@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
groqd ⬜️ Ignored (Inspect) Aug 4, 2023 3:45pm

carloskelly13
carloskelly13 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Since we want to avoid mutation and side effects is it worth doing a structuredClone or similarly to this.value() when we create the new class?

@gksander gksander merged commit c67bd66 into main Aug 8, 2023
4 checks passed
@gksander gksander deleted the return-new-class branch August 8, 2023 17:30
@github-actions github-actions bot mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carloskelly13 carloskelly13 carloskelly13 approved these changes

@maxyinger maxyinger Awaiting requested review from maxyinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gksander @carloskelly13