Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always return new instance #211

Merged
merged 1 commit into from
Aug 8, 2023
+17 −6
Merged

Always return new instance #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/moody-spoons-thank.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"groqd": patch
---

Always return a new Class from builder methods, addresses #204.
18 changes: 12 additions & 6 deletions packages/groqd/src/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,10 @@ export class ArrayQuery<T extends z.ZodTypeAny> extends BaseQuery<
}

filter(filterValue = "") {
this.query += `[${filterValue}]`;
return this;
return new ArrayQuery<T>({
...this.value(),
query: this.query + `[${filterValue}]`,
});
}

filterByType(filterTypeValue: string) {
Expand Down Expand Up @@ -200,13 +202,17 @@ export class ArrayQuery<T extends z.ZodTypeAny> extends BaseQuery<
}

order(...orderings: `${string} ${"asc" | "desc"}`[]): ArrayQuery<T> {
this.query += `|order(${orderings.join(", ")})`;
return this;
return new ArrayQuery<T>({
...this.value(),
query: this.query + `|order(${orderings.join(", ")})`,
});
}

score(...scores: string[]): ArrayQuery<T> {
this.query += `|score(${scores.join(", ")})`;
return this;
return new ArrayQuery<T>({
...this.value(),
query: this.query + `|score(${scores.join(", ")})`,
});
}

// Slicing
Expand Down
Loading