fix(sanityImage): _key as undefined instead of nullable
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tutods is attempting to deploy a commit to the formidable-labs Team on Vercel. A member of the Team first needs to authorize it. |
gksander
reviewed
Sep 25, 2023
| _key: schemas.string().nullable(), | ||
| _key: schemas.string().optional(), |
There was a problem hiding this comment.
There's a small problem with this. The refBase variable gets used in toGrab – and toGrab is used inside of a .grab projection call. This means that the query generated has something like { _key } in it. If you request a field that's absent, the result is null – and not undefined. Therefore this change would likely throw an error for missing _keys.
There was a problem hiding this comment.
Ok I understand, any idea how to fix the error I'm having for example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this pull request, I'm changing the
sanityImagetypes to use_keyasundefinedinstead ofnull.I think with this change, the error I have using the
PortableText(React) will be fixed.Error screenshot: