Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sanityImage): _key as undefined instead of nullable #223

Closed
wants to merge 1 commit into from
Closed

fix(sanityImage): _key as undefined instead of nullable #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/groqd/src/sanityImage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const hotspotFields = {
};

const refBase = {
_key: schemas.string().nullable(),
_key: schemas.string().optional(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small problem with this. The refBase variable gets used in toGrab – and toGrab is used inside of a .grab projection call. This means that the query generated has something like { _key } in it. If you request a field that's absent, the result is null – and not undefined. Therefore this change would likely throw an error for missing _keys.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I understand, any idea how to fix the error I'm having for example?

_type: schemas.string(),
} as const;

Expand Down
Loading