Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(DependencyInjection): move configurate in compiler passes #107

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

gaelreyrol
Copy link
Contributor

@gaelreyrol gaelreyrol commented Dec 22, 2024

Closes #63, #64.

@gaelreyrol gaelreyrol self-assigned this Dec 22, 2024
@gaelreyrol gaelreyrol force-pushed the refactor/move-service-configuration-compiler-pass branch 2 times, most recently from d8c7610 to f41fb4a Compare January 13, 2025 13:51
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 77.88462% with 23 lines in your changes missing coverage. Please review.

Project coverage is 88.22%. Comparing base (0b41a5c) to head (0601912).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ncyInjection/Compiler/CacheInstrumentationPass.php 57.89% 16 Missing ⚠️
...jection/Compiler/HttpClientInstrumentationPass.php 72.72% 3 Missing ⚠️
...Injection/Compiler/DoctrineInstrumentationPass.php 80.00% 1 Missing ⚠️
...cyInjection/Compiler/MailerInstrumentationPass.php 88.88% 1 Missing ⚠️
...njection/Compiler/MessengerInstrumentationPass.php 93.33% 1 Missing ⚠️
...encyInjection/Compiler/TwigInstrumentationPass.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #107      +/-   ##
============================================
- Coverage     88.53%   88.22%   -0.31%     
+ Complexity      635      629       -6     
============================================
  Files           117      117              
  Lines          2616     2625       +9     
============================================
  Hits           2316     2316              
- Misses          300      309       +9     
Flag Coverage Δ
phpunit 88.22% <77.88%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 13, 2025

Coverage Status

coverage: 88.441% (-0.4%) from 88.791%
when pulling 0601912 on refactor/move-service-configuration-compiler-pass
into 0b41a5c on main.

@gaelreyrol gaelreyrol force-pushed the refactor/move-service-configuration-compiler-pass branch from 446412a to 44470fb Compare January 13, 2025 14:53
@gaelreyrol gaelreyrol marked this pull request as ready for review January 13, 2025 14:54
@gaelreyrol gaelreyrol requested a review from a team as a code owner January 13, 2025 14:54
@gaelreyrol gaelreyrol force-pushed the refactor/move-service-configuration-compiler-pass branch from 44470fb to 6e3014b Compare January 13, 2025 14:56
@gaelreyrol gaelreyrol force-pushed the refactor/move-service-configuration-compiler-pass branch from 6e3014b to 0601912 Compare January 13, 2025 15:47
@gaelreyrol gaelreyrol merged commit f20a9c0 into main Jan 13, 2025
8 of 11 checks passed
@gaelreyrol gaelreyrol deleted the refactor/move-service-configuration-compiler-pass branch January 13, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move service decoration in compiler passes
2 participants