Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made o1 temperature issue a warning, instead of valueerror #669

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Made o1 temperature issue a warning, instead of valueerror #669

merged 2 commits into from
Nov 7, 2024

Conversation

whitead
Copy link
Collaborator

@whitead whitead commented Nov 7, 2024

see title

@whitead whitead marked this pull request as ready for review November 7, 2024 16:46
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 7, 2024
@dosubot dosubot bot added the bug Something isn't working label Nov 7, 2024
@whitead whitead requested a review from mskarlin November 7, 2024 16:46
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
@whitead whitead enabled auto-merge (squash) November 7, 2024 16:48
@whitead whitead merged commit 02686ef into main Nov 7, 2024
5 checks passed
@whitead whitead deleted the o1-warning branch November 7, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadolskit nadolskit nadolskit approved these changes

@mskarlin mskarlin Awaiting requested review from mskarlin

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whitead @nadolskit