Made o1 temperature issue a warning, instead of valueerror

paperqa/settings.py

@@ -690,10 +690,13 @@ def _validate_temperature_for_o1_preview(self) -> Self:
         https://platform.openai.com/docs/guides/reasoning/quickstart
         """
         if self.llm.startswith("o1-") and self.temperature != 1:
-            raise ValueError(
-                "When dealing with OpenAI o1 models, the temperature"
-                f" must be set to 1, {self.temperature} was specified."
+            warnings.warn(
+                "When dealing with OpenAI o1 models, the temperature must be set to 1."
+                f" The specified temperature {self.temperature} has been overridden to 1.",
+                category=UserWarning,
+                stacklevel=2,
             )
+            self.temperature = 1
         return self
 
     @computed_field  # type: ignore[prop-decorator]

tests/test_configs.py

@@ -1,3 +1,4 @@
+import warnings
 from unittest.mock import patch
 
 import pytest
@@ -70,6 +71,14 @@ def test_router_kwargs_present_in_models() -> None:
 
 
 def test_o1_requires_temp_equals_1() -> None:
-    with pytest.raises(ValidationError):
-        _ = Settings(llm="o1-thismodeldoesnotexist", temperature=0)
-    _ = Settings(llm="o1-thismodeldoesnotexist", temperature=1)
+    with warnings.catch_warnings(record=True) as w:
+        warnings.simplefilter("always")
+        s = Settings(llm="o1-thismodeldoesnotexist", temperature=0)
+        assert "temperature must be set to 1" in str(w[-1].message)
+        assert s.temperature == 1
+
+    # Test that temperature=1 produces no warning
+    with warnings.catch_warnings(record=True) as w:
+        warnings.simplefilter("always")
+        _ = Settings(llm="o1-thismodeldoesnotexist", temperature=1)
+        assert not w