Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update built with in footer #703

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Update built with in footer #703

merged 3 commits into from
Dec 18, 2024

Conversation

debjudy
Copy link
Contributor

@debjudy debjudy commented Dec 16, 2024

Changes proposed in this pull request

security considerations

[Note the any security considerations here, or make note of why there are none]

@debjudy debjudy requested a review from a team as a code owner December 16, 2024 21:14
@wesley-dean-gsa
Copy link
Contributor

Preview This Branch

You may view the preview version of the site with the following URL:

https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/debjudy-patch-1/

It may take a minute before changes in this Pull Request (PR) show up ⏱️

@debjudy debjudy changed the title Debjudy patch 1 Update built with in footer Dec 16, 2024
@wesley-dean-gsa
Copy link
Contributor

wesley-dean-gsa commented Dec 16, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.92% (-0.24% 🔻)
230/307
🟡 Branches 75.8% 166/219
🟢 Functions
80.65% (-2.69% 🔻)
25/31
🟡 Lines
74.92% (-0.24% 🔻)
230/307
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 global.js
91.89% (-0.84% 🔻)
91.74%
88.89% (-5.23% 🔻)
91.89% (-0.84% 🔻)

Test suite run failed

Failed tests: 2/83. Failed suites: 1/22.
  ● imageShortcode › should generate an img tag with the correct src and alt, using default class

    TypeError: imageShortcode is not a function

      12 |
      13 |     // Call imageShortcode and capture the result
    > 14 |     const result = await imageShortcode("test-image.jpg", "Test Image");
         |                          ^
      15 |
      16 |     // Ensure the result matches the expected HTML string
      17 |     expect(result).toBe(mockResult); // Check if the result matches the mocked output

      at Object.imageShortcode (_tests/imageShortcode.js:14:26)

  ● imageShortcode › should throw an error if image processing fails

    TypeError: imageShortcode is not a function

      26 |
      27 |     // Test that the error is thrown correctly
    > 28 |     await expect(imageShortcode("test-image.jpg", "Test Image")).rejects.toThrow("Image processing failed");
         |                  ^
      29 |   });
      30 | });
      31 |

      at Object.imageShortcode (_tests/imageShortcode.js:28:18)

Report generated by 🧪jest coverage report action from 60bd9a8

@wesley-dean-gsa
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY checkov yes no 13.9s
✅ REPOSITORY gitleaks yes no 0.2s
✅ REPOSITORY git_diff yes no 0.14s
✅ REPOSITORY grype yes no 9.49s
✅ REPOSITORY secretlint yes no 2.13s
✅ REPOSITORY trivy yes no 4.85s
✅ REPOSITORY trufflehog yes no 2.36s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@wesley-dean-gsa wesley-dean-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you so much!

Copy link
Contributor

@wesley-dean-gsa wesley-dean-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you so much!

@debjudy debjudy merged commit f776ad8 into staging Dec 18, 2024
13 checks passed
@debjudy debjudy deleted the debjudy-patch-1 branch December 18, 2024 14:42
@debjudy debjudy mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants