Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt wastewater story text #1017

Merged

Conversation

fengelniederhammer
Copy link
Contributor

resolves #1014

@mcarrara-bioinfo, you're welcome to check in the preview deployment whether the text looks as expected. Are the changes from "Zürich" to "Zurich" intentional?

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cov-spectrum-develop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 1:27pm

@mcarrara-bioinfo
Copy link
Contributor

Thank you for taking the time!
The points you raise are all correct:

  • the line Locations discontinued since March 26th should include the date 2024
  • All instance of Zurich should instead be Zürich

Apart from that, everything looks perfect. After the changes I mentioned you can deploy the changes

@fengelniederhammer
Copy link
Contributor Author

There are still two occurences of "Zurich" on the page:
Until end of May 2022, three times a week the Cantonal Laboratory Zurich (KLZH) provided samples that assess the Canton of Zurich by pooling samples from 12 plants across the canton, [...].
I left them there as they seem correct to me and they have already been there before these changes.

@mcarrara-bioinfo
Copy link
Contributor

Thank you very much

Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengelniederhammer fengelniederhammer merged commit 3df6faa into develop Sep 9, 2024
8 checks passed
@fengelniederhammer fengelniederhammer deleted the 1014-update-text-wastewater-in-switzerland branch September 9, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update text: Wastewater in Switzerland
3 participants