Open
Conversation
Collaborator
Author
|
This PR does have conflict with PR #114 , I'll wait for that one to merge and then rebase this one on top of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #82.
If a workload throws an error (during initialization or running) or timeout, we show a warning on the result page and notify the user. I have tested the following situations:
We can see the number of the iterations in the shown table for the workload:
I also tested if the heights of the warning box is dynamic based on the number of the failed workloads and if it is not shown if all the workloads are successful.
This change has two possible issues which we can fix in follow-up PRs, if we decided to fix them: