Filtering informerFactory to only return relevant PodSpec information #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM Just to confirm, you are using 1.27+ informer library, right? Only in that version you can change the object in place, see https://github.com/kubernetes/client-go/blob/67da6d1a4174c5f881389516fd53f5e13d3eaf85/tools/cache/delta_fifo.go#L146-L147 |
Considering this is 1.27/v0.27.0, we are using v0.30.3. Thanks for the LGTM! |
halimsam
force-pushed
the
trim-pod-spec
branch
from
8d01e2c to
e79ae44
Compare
|
/lgtm |
saikat-royc
reviewed
Dec 19, 2024
halimsam
force-pushed
the
trim-pod-spec
branch
from
e79ae44 to
86ad8ea
Compare
|
I think we need to grab status as well in order to handle the non-sidecar container Job handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering informerFactory to only return relevant PodSpec information to improve GCSFUSE CSI driver memory usage for pods and deployments with larger Pod Specs.