[testing-on-gke part 1.1] Add fio/dlio workload-config parsers #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2264 +/- ##
=======================================
Coverage 71.36% 71.37%
=======================================
Files 106 106
Lines 11560 11560
=======================================
+ Hits 8250 8251 +1
+ Misses 2960 2959 -1
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gargnitingoogle
changed the title
This was referenced Aug 2, 2024
gargnitingoogle
requested review from
vadlakondaswetha
and removed request for
a team
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-new-code/v1
branch
from
6eb4b67 to
a8b17c3
Compare
gargnitingoogle
changed the base branch from
garnitin/add-gke-load-testing/add-origin-csi-driver-code/v1
to
garnitin/add-gke-load-testing/add-origin-csi-driver-code/v2
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-origin-csi-driver-code/v2
branch
from
6e5f57b to
c009a3b
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-new-code/v1
branch
from
d9d3ee0 to
e4f6c08
Compare
gargnitingoogle
commented
Aug 6, 2024
gargnitingoogle
commented
Aug 6, 2024
perfmetrics/scripts/testing_on_gke/examples/dlio/dlio_workload.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/testing_on_gke/examples/dlio/dlio_workload.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/testing_on_gke/examples/dlio/dlio_workload.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/testing_on_gke/examples/dlio/dlio_workload.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/testing_on_gke/examples/dlio/dlio_workload.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/testing_on_gke/examples/dlio/dlio_workload.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/testing_on_gke/examples/fio/fio_workload.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/testing_on_gke/examples/dlio/dlio_workload.py
Outdated
Show resolved
Hide resolved
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-origin-csi-driver-code/v2
branch
from
c009a3b to
1ed3bea
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-new-code/v1
branch
from
e4f6c08 to
ab78513
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-origin-csi-driver-code/v2
branch
from
1ed3bea to
cd38791
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-new-code/v1
branch
from
ab78513 to
9f971fd
Compare
gargnitingoogle
changed the title
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-origin-csi-driver-code/v2
branch
from
cd38791 to
35dd354
Compare
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-new-code/v1
branch
from
2e21e96 to
0e991c4
Compare
Base automatically changed from
garnitin/add-gke-load-testing/add-origin-csi-driver-code/v2
to
master
August 8, 2024 09:46
gargnitingoogle
force-pushed
the
garnitin/add-gke-load-testing/add-new-code/v1
branch
from
0e991c4 to
3b98dcf
Compare
kislaykishore
approved these changes
Aug 8, 2024
gargnitingoogle
deleted the
garnitin/add-gke-load-testing/add-new-code/v1
branch
Tulsishah
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Add fio/dlio workload-config parsers * improve readability * fix dlio workload parser * combine workloads into one * add unit tests for fio_workload * add unit tests for dlio_workload * add strict type and value checking in dlio_workload * add strict type and value checking in fio_workload * update types of values in workloads.json * fix code dependent on type/value checking * improve error messages * minor readability fix * address self-review comments * address some self-review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds on top of #2247, #2284 .
This adds workload configuration files and parsers for FIO and DLIO (unet3d) workloads.
This is followed up in #2268 .
Link to the issue in case of a bug fix.
NA
Testing details