Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing-on-gke part 1.3] Allow any generic machine-type, and passing GCSFuse configuration, workload configuration in the pod configuration #2270

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Aug 2, 2024

Description

This adds on top of #2247, #2284 #2264 and #2268 .

This is followed up in #2271 .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle changed the title [[testing-on-gke part 3] Support gcsfuse-generic scenario and any machine-type in pods [testing-on-gke part 3] Support gcsfuse-generic scenario and any machine-type in pods Aug 2, 2024
@gargnitingoogle gargnitingoogle changed the base branch from master to garnitin/add-gke-load-testing/add-new-code/v2 August 2, 2024 12:33
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.06%. Comparing base (ed2ee46) to head (fcacc63).
Report is 1 commits behind head on garnitin/add-gke-load-testing/add-new-code/v2.

Additional details and impacted files
@@                                Coverage Diff                                @@
##           garnitin/add-gke-load-testing/add-new-code/v2    #2270      +/-   ##
=================================================================================
+ Coverage                                          78.70%   79.06%   +0.35%     
=================================================================================
  Files                                                105      105              
  Lines                                              11690    11620      -70     
=================================================================================
- Hits                                                9201     9187      -14     
+ Misses                                              2029     1972      -57     
- Partials                                             460      461       +1     
Flag Coverage Δ
unittests 79.06% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch 2 times, most recently from 20bf1f5 to aff7324 Compare August 5, 2024 12:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from 84201bf to 223ba71 Compare August 5, 2024 12:22
@gargnitingoogle gargnitingoogle marked this pull request as ready for review August 5, 2024 12:22
@gargnitingoogle gargnitingoogle requested a review from a team as a code owner August 5, 2024 12:22
@gargnitingoogle gargnitingoogle requested review from vadlakondaswetha and removed request for a team August 5, 2024 12:22
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from aff7324 to 5c9cd16 Compare August 6, 2024 07:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from 223ba71 to 78ae880 Compare August 6, 2024 08:38
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 5c9cd16 to 394d34f Compare August 6, 2024 08:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from 78ae880 to 087e09a Compare August 6, 2024 09:00
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 394d34f to 6469044 Compare August 6, 2024 09:04
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from 087e09a to d31df26 Compare August 6, 2024 09:04
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 6469044 to 8360569 Compare August 6, 2024 10:30
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from d31df26 to ce59323 Compare August 6, 2024 10:30
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 8360569 to 2f15628 Compare August 7, 2024 11:29
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from ce59323 to ccf69bb Compare August 7, 2024 11:32
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 2f15628 to 3d2b66f Compare August 7, 2024 15:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch 2 times, most recently from 8efed45 to c2cd169 Compare August 7, 2024 15:53
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 3] Support gcsfuse-generic scenario and any machine-type in pods [testing-on-gke part 1.3] Support gcsfuse-generic scenario and any machine-type in pods Aug 8, 2024
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from a430524 to adb7a41 Compare August 8, 2024 13:11
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from 1e255be to 96116f1 Compare August 8, 2024 13:12
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from adb7a41 to 71570f3 Compare August 8, 2024 15:38
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from 96116f1 to 1f5b96a Compare August 8, 2024 15:39
@gargnitingoogle gargnitingoogle requested review from kislaykishore and removed request for vadlakondaswetha August 9, 2024 05:30
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 71570f3 to 97cd4a8 Compare August 9, 2024 15:17
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from 1f5b96a to beead4e Compare August 9, 2024 15:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 97cd4a8 to 65de360 Compare August 12, 2024 06:36
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from beead4e to beddb38 Compare August 12, 2024 06:36
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 1.3] Support gcsfuse-generic scenario and any machine-type in pods [testing-on-gke part 1.3] Allow any generic machine-type, and passing GCSFuse configuration, workload configuration in the pod configuration Aug 14, 2024
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 65de360 to f6c47eb Compare August 14, 2024 10:48
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch 2 times, most recently from d6d9820 to de7e5e6 Compare August 14, 2024 11:39
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 07ba59d to 8fcfb01 Compare August 19, 2024 05:12
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from de7e5e6 to ca099b5 Compare August 19, 2024 05:12
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 8fcfb01 to 522cde5 Compare August 19, 2024 08:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from ca099b5 to 8f78aed Compare August 19, 2024 08:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v2 branch from 522cde5 to ed2ee46 Compare August 19, 2024 15:14
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v3 branch from 8f78aed to fcacc63 Compare August 19, 2024 15:14
@gargnitingoogle gargnitingoogle merged commit 7c6b661 into garnitin/add-gke-load-testing/add-new-code/v2 Aug 20, 2024
6 checks passed
@gargnitingoogle
Copy link
Collaborator Author

Unintentionally closed because of the wrong dst branch. Reopened in #2367 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants