[Issue #3646] Better Agency display and sort in Search #3686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdragon
requested review from
acouch,
andycochran,
btabaska,
chouinar and
coilysiren
as code owners
1 task
|
Revisiting this on a different branch with API support for multi-column sort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3646
Time to review: 5 mins
Changes proposed
Display both the top level agency and agency name for search results. Sort accordingly when sorting by Agency.
Context for reviewers
Search results now display - or just agency name if the agency is a top level agency. Sorting now takes into account that an agency sort should sort by both top level and agency name fields.