test and lint fixes

frontend/src/components/search/SearchResultsListItem.tsx

@@ -2,14 +2,14 @@
 
 import { Opportunity } from "src/types/search/searchResponseTypes";
 import { formatDate } from "src/utils/dateUtil";
-import { AgencyNamyLookup } from "src/utils/search/generateAgencyNameLookup";
+import { AgencyNameLookup } from "src/utils/search/generateAgencyNameLookup";
 
 import { useTranslations } from "next-intl";
 import Link from "next/link";
 
 interface SearchResultsListItemProps {
   opportunity: Opportunity;
-  agencyNameLookup?: AgencyNamyLookup;
+  agencyNameLookup?: AgencyNameLookup;
 }
 
 export default function SearchResultsListItem({

frontend/src/services/globalState/GlobalStateProvider.tsx

@@ -64,5 +64,5 @@ export const useGlobalState = <T extends Partial<GlobalState>>(
     throw new Error("useGlobalState must be used within GlobalStateProvider");
   }
 
-  return useStore(globalStateStore, useShallow(selector)) as T;
+  return useStore(globalStateStore, useShallow(selector));
 };

frontend/tests/components/search/SearchFilterAccordion/AgencyFilterAccordion.test.tsx

@@ -14,13 +14,13 @@ jest.mock("next-intl", () => ({
 jest.mock("src/hooks/useSearchParamUpdater", () => ({
   useSearchParamUpdater: () => ({
     searchParams: new ReadonlyURLSearchParams(),
-    updateQueryParams: () => {},
+    updateQueryParams: () => undefined,
   }),
 }));
 
 jest.mock("src/services/globalState/GlobalStateProvider", () => ({
   useGlobalState: () => ({
-    setAgencyOptions: () => {},
+    setAgencyOptions: () => undefined,
   }),
 }));
 

frontend/tests/components/search/SearchFilterAccordion/SearchFilterAccordion.test.tsx

@@ -41,6 +41,12 @@ jest.mock("src/hooks/useSearchParamUpdater", () => ({
   }),
 }));
 
+jest.mock("src/services/globalState/GlobalStateProvider", () => ({
+  useGlobalState: () => ({
+    setAgencyOptions: () => undefined,
+  }),
+}));
+
 describe("SearchFilterAccordion", () => {
   const title = "Test Accordion";
   const queryParamKey = "fundingInstrument";

frontend/tests/components/search/SearchFilters.test.tsx

@@ -23,6 +23,12 @@ jest.mock("next-intl", () => ({
   useTranslations: () => useTranslationsMock(),
 }));
 
+jest.mock("src/services/globalState/GlobalStateProvider", () => ({
+  useGlobalState: () => ({
+    setAgencyOptions: () => undefined,
+  }),
+}));
+
 // otherwise we have to deal with mocking suspense
 jest.mock(
   "src/components/search/SearchFilterAccordion/AgencyFilterAccordion",

frontend/tests/pages/search/page.test.tsx

@@ -57,6 +57,12 @@ jest.mock("react", () => ({
   use: jest.fn((e: { [key: string]: string }) => e),
 }));
 
+jest.mock("src/services/globalState/GlobalStateProvider", () => ({
+  useGlobalState: () => ({
+    agencyOptions: [],
+  }),
+}));
+
 const fetchMock = jest.fn().mockResolvedValue({
   json: jest.fn().mockResolvedValue({ data: [], errors: [], warnings: [] }),
   ok: true,

frontend/tests/services/fetch/fetchers/agenciesFetcher.test.ts

@@ -1,4 +1,3 @@
-import { deepStrictEqual } from "assert";
 import {
   agenciesToFilterOptions,
   getAgenciesForFilterOptions,
@@ -39,11 +38,11 @@ const mockfetchAgencies = jest
 const mockSortFilterOptions = jest.fn();
 
 jest.mock("src/services/fetch/fetchers/fetchers", () => ({
-  fetchAgencies: (arg: unknown) => mockfetchAgencies(arg),
+  fetchAgencies: (arg: unknown): unknown => mockfetchAgencies(arg),
 }));
 
 jest.mock("src/utils/search/searchUtils", () => ({
-  sortFilterOptions: (arg: unknown) => mockSortFilterOptions(arg),
+  sortFilterOptions: (arg: unknown): unknown => mockSortFilterOptions(arg),
 }));
 
 describe("obtainAgencies", () => {