avoid collision between striker and striker supporter#1934
Open
vivi-enne wants to merge 4 commits intoHULKs:mainfrom
Open
avoid collision between striker and striker supporter#1934vivi-enne wants to merge 4 commits intoHULKs:mainfrom
vivi-enne wants to merge 4 commits intoHULKs:mainfrom
Conversation
schluis
requested changes
Jul 15, 2025
Contributor
schluis
left a comment
schluis
left a comment
There was a problem hiding this comment.
Seems as this could work 🤔
Comment on lines
101
to
108
| let is_opponent_kickoff = if let Some(filtered_game_controller_state) = | ||
| &world_state.filtered_game_controller_state | ||
| { | ||
| filtered_game_controller_state.kicking_team == Some(Team::Opponent) |
Contributor
There was a problem hiding this comment.
This doesn't seem to only apply during a kickoff. See here: determine_playing_situation in kick_selector.rs.
This also triggers, if a kickoff during the game occurs, and not exclusively, if the robots are walking into the field from the sidelines. I think you have to find a way to distinguish this.
Contributor
Author
There was a problem hiding this comment.
Good catch, thanks. I hope it is fixed now. I now check also for the first kick_off, which is after initial.
vivi-enne
force-pushed
the
anti-collision
branch
from
3feae70 to
24b022d
Compare
…he field Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
vivi-enne
force-pushed
the
anti-collision
branch
from
24b022d to
1ded25e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
To avoid collisions between striker and striker supporter when entering the field for opponent kickoff, the path of the striker supporter (4) is split into two segments depending on a path checkpoint.
Fixes #1298
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
We tested it in the bevyhavior simulator so far because we need a field. Run the
golden_goal_opponent_kickoffin the bevyhavior simulator and there should still not be a collision ingolden_goal.