Split Action and MotionCommand Initial into Initial and Standby#2090
Open
alexschmander wants to merge 1 commit intoHULKs:mainfrom
Open
Split Action and MotionCommand Initial into Initial and Standby#2090alexschmander wants to merge 1 commit intoHULKs:mainfrom
Action and MotionCommand Initial into Initial and Standby#2090alexschmander wants to merge 1 commit intoHULKs:mainfrom
Conversation
alexschmander
added
cat:Behavior
is:Refactoring
alexschmander
changed the title
Action and MotionCommand Initial into Initialand StandbyAction and MotionCommand Initial into Initial and Standby
alexschmander
force-pushed
the
refactor-visual-referee-actions
branch
from
a4f70d8 to
9a25fe3
Compare
Currently, the `Initial` `Action` and `MotionCommand` are used during game state Initial and Standby. This is confusion and should be cleaned up. Additionally, there is currently no way of using the `LookAtReferee` `HeadMotion` without aactivting pose detection. This PR adds a `Standby` `Action` and `MotionCommand`, replacing the `Initial` ones when used in the `Standby` game state. Pose detection is now activated by using `HeadMotion::LookAtReferee` in either `MotionCommand::Standby` or `Stand`.
alexschmander
force-pushed
the
refactor-visual-referee-actions
branch
from
9a25fe3 to
ebd61ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
Currently, the
InitialActionandMotionCommandare used during game state Initial and Standby. This is confusion and should be cleaned up. Additionally, there is currently no way of using theLookAtRefereeHeadMotionwithout aactivting pose detection. This PR adds aStandbyActionandMotionCommand, replacing theInitialones when used in theStandbygame state. Pose detection is now activated by usingHeadMotion::LookAtRefereein eitherMotionCommand::StandbyorStand.Fixes #2061
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test