Skip to content

Comments

No hardcoded image dimensions in twix#2204

Merged
oleflb merged 2 commits intoHULKs:mainfrom
oleflb:twix-no-hardcoded-image-dimensions
Jan 28, 2026
Merged

No hardcoded image dimensions in twix#2204
oleflb merged 2 commits intoHULKs:mainfrom
oleflb:twix-no-hardcoded-image-dimensions

Conversation

@oleflb
Copy link
Contributor

@oleflb oleflb commented Jan 25, 2026

Why? What?

Based on #2203 #2182
Uses the image dimensions in the image instead of the previous hardcoded values.

Fixes #

ToDo / Known Issues

If this is a WIP describe which problems are to be fixed.

Ideas for Next Iterations (Not This PR)

If there are some improvements that could be done in a next iteration, describe them here.

How to Test

  • Subscribe different images in twix

@oleflb oleflb added tools:Debug Tooling Related to twix et.al. is:Easy labels Jan 25, 2026
@github-project-automation github-project-automation bot moved this to Request for Review in Development Jan 25, 2026
@oleflb oleflb enabled auto-merge January 25, 2026 13:59
@knoellle knoellle self-assigned this Jan 27, 2026
Copy link
Member

@knoellle knoellle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleflb oleflb added this pull request to the merge queue Jan 28, 2026
Merged via the queue into HULKs:main with commit bce1bea Jan 28, 2026
22 checks passed
@oleflb oleflb deleted the twix-no-hardcoded-image-dimensions branch January 28, 2026 13:23
@github-project-automation github-project-automation bot moved this from Request for Review to Done in Development Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:Easy tools:Debug Tooling Related to twix et.al.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants