Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end dev #49

Merged
merged 68 commits into from
Feb 8, 2024
Merged

Front end dev #49

merged 68 commits into from
Feb 8, 2024

Conversation

KorenMary
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (4d14a2b) 87.60% compared to head (8661eeb) 88.65%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/client/dcp_client/gui/napari_window.py 77.58% 26 Missing ⚠️
src/client/test/test_napari_window.py 84.61% 8 Missing ⚠️
src/client/dcp_client/utils/utils.py 94.91% 3 Missing ⚠️
src/client/dcp_client/gui/welcome_window.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   87.60%   88.65%   +1.04%     
==========================================
  Files          22       24       +2     
  Lines        1452     1736     +284     
==========================================
+ Hits         1272     1539     +267     
- Misses        180      197      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christinab12 christinab12 self-requested a review December 13, 2023 13:24
Copy link
Collaborator

@christinab12 christinab12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mariia, please take a look at my comments. The key take-aways here are:

  • Always include comments on the functionality of your functions
  • Go through your code once at the end of your development and remove any lines which are not being used
  • If variables are used only within a class function you don't need to assign it as a class variable
  • Good practise is to split code for front-end features and any functionality. It helps readability and keeps things clean!
    Please implement these changes and let me know if you have any questions! Thanks :)

src/client/dcp_client/gui/napari_window.py Outdated Show resolved Hide resolved
src/client/dcp_client/gui/napari_window.py Show resolved Hide resolved
src/client/dcp_client/gui/napari_window.py Outdated Show resolved Hide resolved
src/client/dcp_client/gui/napari_window.py Outdated Show resolved Hide resolved
src/client/dcp_client/gui/napari_window.py Outdated Show resolved Hide resolved
src/client/dcp_client/gui/napari_window.py Outdated Show resolved Hide resolved
src/client/dcp_client/gui/napari_window.py Outdated Show resolved Hide resolved
src/client/dcp_client/gui/napari_window.py Outdated Show resolved Hide resolved
src/client/dcp_client/gui/napari_window.py Outdated Show resolved Hide resolved
src/client/dcp_client/gui/napari_window.py Outdated Show resolved Hide resolved
@christinab12 christinab12 merged commit bdab7c9 into main Feb 8, 2024
13 of 14 checks passed
@christinab12 christinab12 deleted the front-end-dev branch February 8, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants