-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front end dev #49
Front end dev #49
Conversation
…ion with only one mask
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 87.60% 88.65% +1.04%
==========================================
Files 22 24 +2
Lines 1452 1736 +284
==========================================
+ Hits 1272 1539 +267
- Misses 180 197 +17 ☔ View full report in Codecov by Sentry. |
…ion with only one mask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mariia, please take a look at my comments. The key take-aways here are:
- Always include comments on the functionality of your functions
- Go through your code once at the end of your development and remove any lines which are not being used
- If variables are used only within a class function you don't need to assign it as a class variable
- Good practise is to split code for front-end features and any functionality. It helps readability and keeps things clean!
Please implement these changes and let me know if you have any questions! Thanks :)
…ure it is cleaned up after tests run
…zoom mode, info on hover
No description provided.