-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End to end #64
End to end #64
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 82.01% 85.61% +3.60%
==========================================
Files 13 20 +7
Lines 706 1314 +608
==========================================
+ Hits 579 1125 +546
- Misses 127 189 +62 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KorenMary,
Thanks for the PR, looks good. Two small things:
- Please see the small change in my commit for future PRs.
- The model doesn't currently accept non-square images, but it should be able to, please adjust accordingly (probably a good idea to an include non-square image in tests to avoid this in future).
Integration of UNet