Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to end #64

Merged
merged 11 commits into from
Jan 24, 2024
Merged

End to end #64

merged 11 commits into from
Jan 24, 2024

Conversation

KorenMary
Copy link
Collaborator

Integration of UNet

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8df82bb) 82.01% compared to head (6cc2d7e) 85.61%.
Report is 37 commits behind head on main.

Files Patch % Lines
src/server/test/synthetic_dataset.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   82.01%   85.61%   +3.60%     
==========================================
  Files          13       20       +7     
  Lines         706     1314     +608     
==========================================
+ Hits          579     1125     +546     
- Misses        127      189      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@christinab12 christinab12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KorenMary,

Thanks for the PR, looks good. Two small things:

  1. Please see the small change in my commit for future PRs.
  2. The model doesn't currently accept non-square images, but it should be able to, please adjust accordingly (probably a good idea to an include non-square image in tests to avoid this in future).

@christinab12 christinab12 merged commit 683e0e4 into main Jan 24, 2024
17 checks passed
@christinab12 christinab12 deleted the end-to-end branch January 24, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants