Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include mask option to the classifier and tested it #66

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

KorenMary
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6999988) 82.07% compared to head (e37b65c) 87.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   82.07%   87.60%   +5.52%     
==========================================
  Files          16       22       +6     
  Lines         848     1452     +604     
==========================================
+ Hits          696     1272     +576     
- Misses        152      180      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christinab12 christinab12 self-requested a review January 11, 2024 14:07
@christinab12
Copy link
Collaborator

PR looks good, but I see that utils has similar changes as Random-Forest branch, we might face a merge conflict there, let's see! Are you sure your tests take include_mask=True? The codecov report suggests otherwise?

@KorenMary
Copy link
Collaborator Author

PR looks good, but I see that utils has similar changes as Random-Forest branch, we might face a merge conflict there, let's see! Are you sure your tests take include_mask=True? The codecov report suggests otherwise?

Yes, I have double-checked in src\server\test\test_config.cfg the include-mask parameter is True. Which test is responsible for this in codecov?

@christinab12 christinab12 merged commit 4d14a2b into main Jan 31, 2024
14 checks passed
@christinab12 christinab12 deleted the include-mask branch January 31, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants