This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
Fix a couple of issues with the web build, caused by CLI changes #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only usable in a native terminal. Including it also makes rollup upset about having to include a binary file from the node-pty library. There is a small hack here: rollup will automatically include anything that's imported, but splitting the imported path into two strings concatenated is enough to fool it into ignoring the file.
`process` only exists when running in Node. Notably, `if (process)` is still a ReferenceError, so the existing check in readline.js needs modifying too. Unfortunately we don't have access to the platform name there, so we just check if `process` exists.
| @@ -83,10 +82,15 @@ export const launchPuterShell = async (ctx) => { | |||
| await sdkv2.setAPIOrigin(source_without_trailing_slash); | |||
| } | |||
|
|
|||
| // PathCommandProvider is only compatible with node.js for now | |||
| // HACK: The import path is split to fool rollup into not including it. | |||
There was a problem hiding this comment.
The fact that this works is hilarious, and now I wonder if webpack or any of the other bundlers do actual AST parsing to handle this (or perhaps fail the same way).
Although, for the moment... 👍 this is a feature rather than a bug - thanks Rollup!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid including PathCommandProvider and its dependencies in the web build, because they're useless there, and they try to include some binary files that make rollup upset.
Also redo the changes originally in #79 because we can read
ctx.platform.namein most places, and that makes the check clearer.