Skip to content
This repository has been archived by the owner on Apr 13, 2024. It is now read-only.

Fix a couple of issues with the web build, caused by CLI changes #81

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Fix a couple of issues with the web build, caused by CLI changes #81

merged 2 commits into from
Apr 12, 2024

Commits on Apr 12, 2024

  1. Stop including PathCommandProvider (and so node-pty) in web build 

    This is only usable in a native terminal. Including it also makes rollup
upset about having to include a binary file from the node-pty library.

There is a small hack here: rollup will automatically include anything
that's imported, but splitting the imported path into two strings
concatenated is enough to fool it into ignoring the file.
    @AtkinsSJ
    AtkinsSJ committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    d20be49 View commit details
    Browse the repository at this point in the history

  2. Guard use of process with checks that we're running on Node 

    `process` only exists when running in Node. Notably, `if (process)` is
still a ReferenceError, so the existing check in readline.js needs
modifying too. Unfortunately we don't have access to the platform name
there, so we just check if `process` exists.
    @AtkinsSJ
    AtkinsSJ committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8ededf6 View commit details
    Browse the repository at this point in the history