Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean the project (#38) #42

Merged
merged 10 commits into from
Oct 15, 2024
Merged

chore: clean the project (#38) #42

merged 10 commits into from
Oct 15, 2024

Conversation

Wylwi
Copy link
Contributor

@Wylwi Wylwi commented Oct 14, 2024

Summary

  • The objective is to clean the project from template files and small issues introduced during the first steps of the project

Details

Depends on the nature of the PR :

  • Removed unused dependencies
  • Resolved issues highlighted by Sonar
  • Change hard-coded colors and datas to use Theming
  • Cleaned the CI
  • Removed no longer relevant files
  • Added line breaks on Pull Request Template

@Wylwi Wylwi changed the title Chore/38 clean up project chore: clean the project (#38) Oct 14, 2024
@Wylwi Wylwi requested a review from MaelImhof October 14, 2024 20:07
@Wylwi Wylwi marked this pull request as ready for review October 14, 2024 20:07
@HikeMate HikeMate deleted a comment from sonarqubecloud bot Oct 14, 2024
@Wylwi Wylwi self-assigned this Oct 14, 2024
@rBergCode rBergCode requested review from rBergCode and removed request for MaelImhof October 15, 2024 08:08
@Wylwi Wylwi force-pushed the chore/38-clean-up-project branch from 4bb33b3 to 852127a Compare October 15, 2024 08:20
@HikeMate HikeMate deleted a comment from sonarqubecloud bot Oct 15, 2024
@HikeMate HikeMate deleted a comment from sonarqubecloud bot Oct 15, 2024
@Wylwi Wylwi force-pushed the chore/38-clean-up-project branch from 852127a to 7a2f072 Compare October 15, 2024 08:30
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
48.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@rBergCode rBergCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job! The project is way cleaner now!

@Wylwi Wylwi merged commit 0185743 into main Oct 15, 2024
2 checks passed
@Wylwi Wylwi deleted the chore/38-clean-up-project branch October 15, 2024 08:41
@Wylwi Wylwi mentioned this pull request Oct 15, 2024
10 tasks
@MaelImhof MaelImhof added the sprint 2 Active during the second sprint label Nov 15, 2024
@MaelImhof MaelImhof added this to the Milestone 1 milestone Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint 2 Active during the second sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants