[FEAT] Feat/group service add #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohksj77
reviewed
Nov 28, 2023
| @@ -111,4 +113,17 @@ public GroupInfoResponse inviteGroup(InviteGroupRequest inviteGroupRequest) { | |||
| public GroupInfoResponse getGroupInfoResponse(Group group) { | |||
| return groupMapper.toGroupInfo(group); | |||
| } | |||
|
|
|||
| @Transactional | |||
| Member loginMember = authService.getMemberByJwt(); | ||
|
|
||
| for (GroupMember groupMember : loginMember.getGroupMembers()) { | ||
| responses.add(groupMapper.toGroupInfo(groupMember.getGroup())); |
There was a problem hiding this comment.
이러면 group이 중복된 경우 어떻게 돼..?
그리고 뭔가 dto 조합하는 과정 전체가 mapper에 있어도 좋을듯!
There was a problem hiding this comment.
그리고 stream 쓰는건 어떻게 생각해? 한 줄로 깔끔하게 나올 것 같음
jinjoo-lab
force-pushed
the
feat/group-service-add
branch
from
0b01514 to
a2aa4d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가/수정한 기능 설명
특이사항
check list