Move system prompt to websocket message #383
Merged
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: richard.marmorstein <richard.marmorstein@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ivaaan
reviewed
Nov 9, 2025
ivaaan
approved these changes
Nov 9, 2025
ivaaan
deleted the
cursor/move-system-prompt-to-websocket-message-db27
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
systemPromptfrom URL query parameters to a post-connect websocket message to prevent URL size limits.The previous implementation could lead to
session_settingsbecoming too large for URL query parameters, particularly when asystemPromptwas included. This change alignssystemPrompthandling withbuiltinToolsandtools, which are already sent via a post-connect websocket message.