Skip to content

Move system prompt to websocket message #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2025
Merged

Move system prompt to websocket message #383

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1670c5a
feat: Add systemPrompt to session settings
cursoragent Nov 6, 2025
48abaa9
Merge branch 'main' into cursor/move-system-prompt-to-websocket-messa…
twitchard Nov 7, 2025
586e2a7
Merge branch 'main' into cursor/move-system-prompt-to-websocket-messa…
ivaaan Nov 9, 2025
ac26907
rm systemPrompt from SessionSettingsOnConnect
ivaaan Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/react/src/lib/useVoiceClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ type SessionSettingsOnConnect = Omit<
>;
type SessionSettingsPostConnect = Pick<
Hume.empathicVoice.SessionSettings,
'builtinTools' | 'tools' | 'metadata' | 'type'
'builtinTools' | 'tools' | 'metadata' | 'type' | 'systemPrompt'
>;
/**
* Some session settings can be sent as query params when the websocket connects.
* This is preferred because it eliminates a race condition of the session settings being applied slightly after the conversation starts.
*
* `tools` and `builtinTools` are not yet supported in the query string. We can remove
* `tools`, `builtinTools`, and `systemPrompt` are not yet supported in the query string. We can remove
* this and send everything in the query string once this changes. For the time being
* we send as many settings as possible in the query string, and then a complete session
* settings message shortly after.
Expand All @@ -52,8 +52,9 @@ const getSessionSettingsOnConnect = (
return {};
}

const { builtinTools, tools, metadata, type, ...onConnect } = sessionSettings;
if (builtinTools || tools || metadata) {
const { builtinTools, tools, metadata, type, systemPrompt, ...onConnect } =
sessionSettings;
if (builtinTools || tools || metadata || systemPrompt) {
return {
onConnect,
postConnect: sessionSettings,
Expand Down