Skip to content

IONOS(build): refactor JFrog properties construction to array-based approach#188

Merged
printminion-co merged 2 commits intomk/dev/jfrog_add_workflow_infofrom
copilot/sub-pr-184-again
Jan 16, 2026
Merged

IONOS(build): refactor JFrog properties construction to array-based approach#188
printminion-co merged 2 commits intomk/dev/jfrog_add_workflow_infofrom
copilot/sub-pr-184-again

Conversation

Copy link

Copilot AI commented Jan 16, 2026

Summary

Refactored JFrog artifact property construction from repeated string concatenation to array-based building. Improves maintainability and reduces error potential when adding/removing properties.

Before (string concatenation):

JFROG_PROPS="app.name=${APP_NAME}"
JFROG_PROPS="${JFROG_PROPS};app.sha=${APP_SHA}"
JFROG_PROPS="${JFROG_PROPS};vcs.branch=${{ github.ref_name }}"
# ...prone to missing semicolons or typos

After (array-based):

JFROG_PROPS_LIST=()
JFROG_PROPS_LIST+=("app.name=${APP_NAME}")
JFROG_PROPS_LIST+=("app.sha=${APP_SHA}")
JFROG_PROPS_LIST+=("vcs.branch=${{ github.ref_name }}")
JFROG_PROPS=$(IFS=';'; printf '%s' "${JFROG_PROPS_LIST[*]}")

Changes:

  • Replaced string concatenation with Bash array operations in both build-external-apps and upload-to-jfrog jobs
  • Used IFS-based joining to construct semicolon-separated property strings
  • Maintained consistent pattern across both upload locations

TODO

  • ...

Checklist


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: printminion-co <145785698+printminion-co@users.noreply.github.com>
Copilot AI changed the title [WIP] Enhance artifact upload process with metadata IONOS(build): refactor JFrog properties construction to array-based approach Jan 16, 2026
Copilot AI requested a review from printminion-co January 16, 2026 09:02
@printminion-co printminion-co marked this pull request as ready for review January 16, 2026 09:03
@printminion-co printminion-co merged commit 0d90f1a into mk/dev/jfrog_add_workflow_info Jan 16, 2026
1 check failed
@printminion-co printminion-co deleted the copilot/sub-pr-184-again branch January 16, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants