Skip to content

IONOS(build): refactor JFrog properties construction to array-based approach #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
printminion-co merged 2 commits into from
Jan 16, 2026
Merged

IONOS(build): refactor JFrog properties construction to array-based approach #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccb209d
Initial plan
Copilot Jan 16, 2026
030ebf5
IONOS(build): refactor JFrog properties to use array-based construction
Copilot Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions .github/workflows/build-artifact.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,15 +358,18 @@ jobs:
JFROG_PATH="${{ env.ARTIFACTORY_REPOSITORY_SNAPSHOT }}/apps/${{ env.CACHE_VERSION }}/${APP_NAME}/${ARCHIVE_NAME}"

# Build properties for artifact metadata
JFROG_PROPS="app.name=${APP_NAME}"
JFROG_PROPS="${JFROG_PROPS};app.sha=${APP_SHA}"
JFROG_PROPS="${JFROG_PROPS};vcs.branch=${{ github.ref_name }}"
JFROG_PROPS="${JFROG_PROPS};vcs.revision=${{ github.sha }}"
JFROG_PROPS_LIST=()
JFROG_PROPS_LIST+=("app.name=${APP_NAME}")
JFROG_PROPS_LIST+=("app.sha=${APP_SHA}")
JFROG_PROPS_LIST+=("vcs.branch=${{ github.ref_name }}")
JFROG_PROPS_LIST+=("vcs.revision=${{ github.sha }}")
# Add job URL if available
JOB_URL="${{ steps.get_job_data.outputs.job_html_url }}"
if [ -n "$JOB_URL" ]; then
JFROG_PROPS="${JFROG_PROPS};job.html_url=$JOB_URL"
JFROG_PROPS_LIST+=("job.html_url=$JOB_URL")
fi
# Join properties into a single semicolon-separated string
JFROG_PROPS=$(IFS=';'; printf '%s' "${JFROG_PROPS_LIST[*]}")

echo ""
echo "Uploading to JFrog..."
Expand Down Expand Up @@ -741,14 +744,17 @@ jobs:
export PATH_TO_LATEST_ARTIFACT="${PATH_TO_DIRECTORY}/${PATH_TO_FILE}"

# Build properties for artifact metadata
JFROG_PROPS="build.nc_version=${{ needs.build-artifact.outputs.NC_VERSION }}"
JFROG_PROPS="${JFROG_PROPS};vcs.branch=${{ github.ref_name }}"
JFROG_PROPS="${JFROG_PROPS};vcs.revision=${{ github.sha }}"
JFROG_PROPS_LIST=()
JFROG_PROPS_LIST+=("build.nc_version=${{ needs.build-artifact.outputs.NC_VERSION }}")
JFROG_PROPS_LIST+=("vcs.branch=${{ github.ref_name }}")
JFROG_PROPS_LIST+=("vcs.revision=${{ github.sha }}")
# Add job URL if available
JOB_URL="${{ steps.get_job_data.outputs.job_html_url }}"
if [ -n "$JOB_URL" ]; then
JFROG_PROPS="${JFROG_PROPS};job.html_url=$JOB_URL"
JFROG_PROPS_LIST+=("job.html_url=$JOB_URL")
fi
# Join properties into a single semicolon-separated string
JFROG_PROPS=$(IFS=';'; printf '%s' "${JFROG_PROPS_LIST[*]}")

# Upload with retry logic (3 attempts with 30s delay)
MAX_ATTEMPTS=3
Expand Down
Loading