-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TD-2263 Adding infofile validator #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, left some suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo in the README.
I've published a pre-release for you so that you can start making use if it in VIRTO as a final test: @ipguk/infofile-utils@1.1.0-0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failing CI
Sorry, turns out file names are case insensitive on windows, but not on linux, hence the unexpected unit test fail here I added a bunch of new types, removed the type "Model", changed the RegEx search pattern when calling without type |
I am done with the testing of the pre-release 1.1.0-1 in Virto, I have not encountered any problems. I looked through the code, this implementation has all the necessary types to use it in Virto-apps, where currently an infofile validation is being used with a local implementation, so I have no plans to expand it with more types now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. merge the PR and drop me a message to do the release
Contributes to TD-2263
Changes
A supporting function for TD-2263, but could be used in other applications too later.
It adds an infofile validator to the infofile-utils. Additionally, I infofiles into the repository for the unit tests. The current options to for infofile validations are :
The basis of the validation is always the "FileIdent" property of the infofile, an appropriate RegEx search is carried out for each of the options listed above.
Dependencies
UI/UX
Testing notes
Author checklist before assigning a reviewer