fixed not recognizing one digit CarMaker versions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the unit tests for the one-digit version numbers |
mattcorner
approved these changes
Apr 9, 2024
mattcorner
deleted the
bug/one-digit-carmaker-version-numbers-not-recognized-as-valid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to TD-2263
Changes
In some cases, the RegEx search patterns in the isValidInfoFile function were looking for version numbers. However, it was looking for double digit version numbers, so CM8 and CM9 would be regarded as invalid. The new seach pattern just looks for the first digit of the version number, so this bug would occurp anymore.
Dependencies
UI/UX
Testing notes
Author checklist before assigning a reviewer