Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add: Tracing via opentelemetry #6168

Merged
merged 162 commits into from
Sep 17, 2024
Merged

✨ Add: Tracing via opentelemetry #6168

merged 162 commits into from
Sep 17, 2024

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Aug 12, 2024 •
edited
Loading

What do these changes do?

  • Adds support for openelemetry-based tracing to all osparc-simcore microservices (except the locked director-v0) by means of aiopg, requests, fastapi and aiohttp autoinstrumentation
  • Removes deprecated zipkin-based tracing
  • [can't be avoided] removes some unused packages dependencies
  • Adds opentelemetry-collector to local developer-ops-stack

Bonus:

  • Fix typos
  • Add some words to coding-conventions.md
  • Make catalog more resilient to losing connection to director-v0

Related PRs

How to test

  1. make up-devel
  2. Do some stuff in oSparc
  3. Observe traces in jaeger.

Dev-ops checklist

Dustin Kaiser and others added 30 commits April 22, 2024 11:43
Add password for redis
40f56aa
Merge remote-tracking branch 'upstream/master' into add/redisWithPass…
f124306 
…word
Merge remote-tracking branch 'upstream/master' into add/redisWithPass…
db7ec97 
…word
@mrnicegyu11
Merge branch 'master' into 2024/07/redisPassword
2adba93
make redis tests pass
6f0f32a
Merge remote-tracking branch 'upstream/master' into 2024/07/redisPass…
7c8f832 
…word
@mrnicegyu11
Merge branch 'master' into 2024/07/redisPassword
e132b7e
@odeimaiz
🎨 [Frontend] TIP v3 Feedback from 10.07 (ITISFoundation#6049)
569bf06
@bisgaard-itis
🎨 Improve load test framework (yet again) (ITISFoundation#6051)
4b490fc
@odeimaiz
🎨 [Frontend] Do not change annotations' color when selected (ITISFoun…
82583e8 
…dation#6048)
@bisgaard-itis
🐛 Fix install-ci make target in tests/performance (ITISFoundation…
5c0c85f 
…#6053)
@sanderegg
✨🚨Autoscaling: Prepare Warmed EBS-backed volumes to use as buffer for…
8f3dcaa 
… machines (⚠️ Devops) 🚨 (ITISFoundation#5923)
@GitHK
🚑️ fixes issue with env vars being stored as dict or list (ITISFounda…
8462789 
…tion#6052)

Co-authored-by: Andrei Neagu <neagu@itis.swiss>
@pcrespov
✨✅ catalog: service-layer for registry and increased test coverage (p…
fd3bd45 
…art 4) (ITISFoundation#6050)
@GitHK
🐛 fixes hanging servicelib tests (ITISFoundation#5942)
77b4ab3 
Co-authored-by: Andrei Neagu <neagu@itis.swiss>
@odeimaiz
🎨 [Frontend] Patch study from Study Editor (ITISFoundation#5916)
4743aee
@dependabot
Bump actions/setup-node from 4.0.2 to 4.0.3 (ITISFoundation#6065)
161c8d4 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bisgaard-itis
🐛🎨 Fix backenderror name injection (ITISFoundation#6064)
2aecc2e
@odeimaiz
🎨 [Frontend] UX: Reuse Add collaborators widget in Publish templa…
6c236d4 
…te (ITISFoundation#6058)
@GitHK
🎨adding logs when sendig socketio messages (ITISFoundation#6067)
12ec93d 
Co-authored-by: Andrei Neagu <neagu@itis.swiss>
@odeimaiz
🎨 [Frontend] UX Cookie Expiration Date (ITISFoundation#6066)
50d318e
@bisgaard-itis
🐛 Fix create soft link kwargs (ITISFoundation#6069)
20d4f8b 
Merged on behalf of @bisgaard-itis . Needed for staging release
@pcrespov
🎨 web-api services api response includes manifest info (part 5) (IT…
3912180 
…ISFoundation#6061)
@mrnicegyu11
Merge branch 'master' into 2024/07/redisPassword
f1440ae
Fix some tests
09cd578
Fix some tests
290dd22
@mrnicegyu11
Merge branch 'master' into 2024/07/redisPassword
6905089
Fix some tests
f7ed2e1
@mrnicegyu11
Merge branch 'master' into 2024/07/redisPassword
540f541
Fix some tests
d04d281
pcrespov
pcrespov approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Go ahead!

PS: i have never seen so many labels together ... reminds me the 🥇 of a a retired general! :-)

packages/service-library/src/servicelib/aiohttp/tracing.py Show resolved Hide resolved
packages/service-library/src/servicelib/aiohttp/tracing.py Show resolved Hide resolved
packages/service-library/src/servicelib/fastapi/tracing.py Show resolved Hide resolved
sanderegg
sanderegg approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my last comments. thanks!

packages/service-library/src/servicelib/aiohttp/tracing.py Show resolved Hide resolved
packages/service-library/src/servicelib/aiohttp/tracing.py Outdated Show resolved Hide resolved
packages/service-library/src/servicelib/aiohttp/tracing.py Show resolved Hide resolved
packages/service-library/tests/aiohttp/test_tracing.py Show resolved Hide resolved
packages/service-library/tests/fastapi/test_openapi.py Show resolved Hide resolved
packages/settings-library/src/settings_library/tracing.py Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mrnicegyu11 mrnicegyu11 enabled auto-merge (squash) September 17, 2024 12:15
@mrnicegyu11 mrnicegyu11 merged commit fb38602 into ITISFoundation:master Sep 17, 2024
57 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2024
Closed
29 tasks
@sanderegg sanderegg mentioned this pull request Sep 19, 2024
Merged
1 task
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

@ignapas ignapas Awaiting requested review from ignapas

Assignees

@mrnicegyu11 mrnicegyu11

Labels
a:agent agent service a:api framework api, data schemas, a:apiserver api-server service a:autoscaling autoscaling service in simcore's stack a:catalog catalog service a:clusters-keeper a:database associated to postgres service and postgres-database package a:director-v2 issue related with the director-v2 service a:dynamic-scheduler a:dynamic-sidecar dynamic-sidecar service a:infra+ops maintenance of infrastructure or operations (discussed in retro) a:invitations invitations service a:payments payments service a:resource-usage-tracker resource usage tracker service a:services-library issues on packages/service-libs a:sidecar issue related with the sidecar worker service a:storage issue related to storage service a:webserver issue related to the webserver service t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Eisbock
Development

Successfully merging this pull request may close these issues.
8 participants
@mrnicegyu11 @GitHK @pcrespov @sanderegg @YuryHrytsuk @matusdrobuliak66 @odeimaiz @bisgaard-itis