Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Workspaces and Folders: Sync tree #6373

Merged
merged 23 commits into from
Sep 17, 2024
Merged

🎨 [Frontend] Workspaces and Folders: Sync tree #6373

merged 23 commits into from
Sep 17, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 16, 2024 •
edited
Loading

What do these changes do?

  • Sync context
  • Init "My Workspace" selected
  • Limit folder's name width @calys

Sync tree

Related issue/s

related to #6315
related to ITISFoundation/osparc-issues#716

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 16, 2024
@odeimaiz odeimaiz added this to the Doppelbock milestone Sep 16, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 17, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 17, 2024 12:03
sanderegg
sanderegg reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool 👍

@odeimaiz odeimaiz enabled auto-merge (squash) September 17, 2024 12:40
@matusdrobuliak66
Copy link
Contributor

The ID of the dashboard/workspace button will be the same as before as it is used in the e2e tests?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pcrespov
pcrespov reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit 2c6692e into ITISFoundation:master Sep 17, 2024
51 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2024
Closed
29 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@calys calys Awaiting requested review from calys

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
7 participants
@odeimaiz @matusdrobuliak66 @jsaq007 @ignapas @GitHK @pcrespov @sanderegg