Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix filtering when project shared with product groups #6379

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Sep 17, 2024

What do these changes do?

  • 🐛 fix filtering when project shared with product groups

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 17, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 17, 2024 12:49
@matusdrobuliak66 matusdrobuliak66 added this to the Doppelbock milestone Sep 17, 2024
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (cafbf96) to head (4466eb4).
Report is 553 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6379      +/-   ##
=========================================
- Coverage    84.5%   82.2%    -2.4%     
=========================================
  Files          10     591     +581     
  Lines         214   30249   +30035     
  Branches       25     260     +235     
=========================================
+ Hits          181   24869   +24688     
- Misses         23    5320    +5297     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 63.4% <ø> (?)
unittests 87.9% <ø> (+3.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/simcore_service_webserver/projects/_db_utils.py 92.3% <ø> (ø)

... and 600 files with indirect coverage changes

@pcrespov pcrespov enabled auto-merge (squash) September 17, 2024 13:57
@mrnicegyu11 mrnicegyu11 merged commit 9b6df59 into ITISFoundation:master Sep 17, 2024
2 checks passed
Copy link

sonarcloud bot commented Sep 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants