-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 backend pulls inputs before iframe is displayed #6392
🎨 backend pulls inputs before iframe is displayed #6392
Conversation
…puts-after-services-start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6392 +/- ##
=========================================
- Coverage 84.5% 68.1% -16.4%
=========================================
Files 10 595 +585
Lines 214 30393 +30179
Branches 25 260 +235
=========================================
+ Hits 181 20728 +20547
- Misses 23 9605 +9582
- Partials 10 60 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, thanks! that is why maintenance tasks are good.
...simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_user_services.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
…puts-after-services-start
Quality Gate passedIssues Measures |
Co-authored-by: Andrei Neagu <neagu@itis.swiss>
What do these changes do?
Allows for inputs to be in place before the iframe is displayed.
Why is this a good idea?
Related issue/s
How to test
Dev-ops checklist