Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 backend pulls inputs before iframe is displayed #6392

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Sep 18, 2024

What do these changes do?

Allows for inputs to be in place before the iframe is displayed.

Why is this a good idea?

  • Some services run code that checks inputs as soon as the iframe is loaded.
  • Some users run their scripts as soon as the service is loaded and since currently there is no visual queue about input ports being pulled this helps them to be sure that the inputs are in place.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Sep 18, 2024
@GitHK GitHK added this to the MartinKippenberger milestone Sep 18, 2024
@GitHK GitHK added t:maintenance Some planned maintenance work t:enhancement Improvement or request on an existing feature and removed t:maintenance Some planned maintenance work labels Sep 18, 2024
@GitHK GitHK marked this pull request as ready for review September 18, 2024 14:53
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.1%. Comparing base (cafbf96) to head (c72122e).
Report is 558 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6392      +/-   ##
=========================================
- Coverage    84.5%   68.1%   -16.4%     
=========================================
  Files          10     595     +585     
  Lines         214   30393   +30179     
  Branches       25     260     +235     
=========================================
+ Hits          181   20728   +20547     
- Misses         23    9605    +9582     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.7% <100.0%> (?)
unittests 84.3% <0.0%> (-0.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c_sidecar/scheduler/_core/_events_user_services.py 86.8% <100.0%> (ø)

... and 604 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks! that is why maintenance tasks are good.

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

sonarcloud bot commented Sep 19, 2024

@GitHK GitHK merged commit dd18d34 into ITISFoundation:master Sep 19, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-pull-inputs-after-services-start branch September 19, 2024 08:10
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attempt pulling inputs bfore displaying iframe for new style services
5 participants