Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Frontend] Fix: Share and Leave Study #6401

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 19, 2024

What do these changes do?

  • Fix: Users with write access can Share with more users
  • Enh: Users should be able to leave a Study (@matusdrobuliak66 will improve the backend, at the moment you need delete access to leave)

LeaveStudy

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 19, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Sep 20, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Sep 20, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 20, 2024 13:30
@odeimaiz odeimaiz changed the title 🐛 [Frontend] Fix: Leave Study 🐛 [Frontend] Fix: Share and Leave Study Sep 20, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) September 20, 2024 13:43
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this related to #6415?
thjx

Copy link

sonarcloud bot commented Sep 23, 2024

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it wasn't clear but I think this was a user leaving a study? In which case is the user still able to open the study? If not surely the Open button should be disabled or removed from the UI. Alternatively it could be switched to an undo leave incase they left by mistake.

@odeimaiz odeimaiz merged commit 50ada4b into ITISFoundation:master Sep 23, 2024
51 checks passed
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Sep 25, 2024
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants