Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Move multiple studies at once #6457

Merged
merged 27 commits into from
Sep 30, 2024
Merged

🎨 [Frontend] Move multiple studies at once #6457

merged 27 commits into from
Sep 30, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 26, 2024 •
edited
Loading

What do these changes do?

  • Move multiple studies at once
  • Merge Move-to-Folder and Move-to-Workspace
  • UI/UX Workspace&Folders tree: In order to avoid the arrow that disappears, go one step ahead the user and load the next level too.
  • UI/UX Loading projects: Updates the "Loading..." card's appearance, now it's just a semi transparent spinning wheel

Move multiple studies at once
MoveMultipleStudies

UI/UX
ArrowsAndSpinners

Related issue/s

closes #6404
related to #6386

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 26, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Sep 26, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 26, 2024
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Merge Move-Folder-to-Folder and Move-Folder-to-Workspace 🎨 [Frontend] Move multiple studies at once Sep 26, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 27, 2024 09:28
matusdrobuliak66
matusdrobuliak66 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

pcrespov
pcrespov reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@matusdrobuliak66 for these features it would be good that we implement batch operations int he rest API, i.e. batchCreate, batchGet, batchDelete, batchUpdate, batchReplace. This way we reduce multiple calls from the front-end

GitHK
GitHK reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) September 30, 2024 08:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jsaq007
jsaq007 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz merged commit a0887c2 into ITISFoundation:master Sep 30, 2024
55 checks passed
@odeimaiz odeimaiz mentioned this pull request Sep 30, 2024
Closed
@odeimaiz odeimaiz deleted the enh/move-projects branch September 30, 2024 13:17
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@odeimaiz
🎨 [Frontend] Move multiple studies at once (ITISFoundation#6457)
54e8174
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 4, 2024
Closed
16 tasks
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@calys calys Awaiting requested review from calys

@cosfor1 cosfor1 Awaiting requested review from cosfor1

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.

Move multiple projects into a folder
5 participants
@odeimaiz @jsaq007 @GitHK @pcrespov @matusdrobuliak66