Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ e2e: Final touches to tip testing #6459

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 27, 2024

What do these changes do?

Enhancements:

  • Logs expected number of expected states transmitted via socketio
  • Dedicated function to check states: received_required_node_progress_types
  • Timeout is ignored only when progress of all required_node_progress_types are received (BUG: Progress bar not achieving 100% #6449)

Related issue/s

@pcrespov pcrespov self-assigned this Sep 27, 2024
@pcrespov pcrespov added the e2e Bugs found by or related to the end-2-end testing label Sep 27, 2024
@pcrespov pcrespov added this to the MartinKippenberger milestone Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.2%. Comparing base (cafbf96) to head (ec575af).
Report is 596 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6459      +/-   ##
=========================================
+ Coverage    84.5%   88.2%    +3.6%     
=========================================
  Files          10    1526    +1516     
  Lines         214   62809   +62595     
  Branches       25    2029    +2004     
=========================================
+ Hits          181   55433   +55252     
- Misses         23    7065    +7042     
- Partials       10     311     +301     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 86.2% <ø> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1476 files with indirect coverage changes

@pcrespov pcrespov changed the title e2e: enhancing tip testing ✅ e2e: Final touches to tip testing Sep 27, 2024
@pcrespov pcrespov marked this pull request as ready for review September 27, 2024 14:59
@pcrespov pcrespov enabled auto-merge (squash) September 27, 2024 14:59
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Copy link

sonarcloud bot commented Sep 27, 2024

@pcrespov pcrespov merged commit 9609abd into ITISFoundation:master Sep 27, 2024
57 checks passed
@pcrespov pcrespov deleted the is1701/tip-lite-tutorial-minor branch September 27, 2024 18:01
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants