Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Frontend] Fix Service browser #6659

Merged
merged 3 commits into from
Nov 4, 2024
Merged

🐛 [Frontend] Fix Service browser #6659

merged 3 commits into from
Nov 4, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 4, 2024 •
edited
Loading

What do these changes do?

  • Fix the Service Browser listing.
  • Fix the undefined unit in the Disk Usage's tooltip

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 4, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 4, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Nov 4, 2024
matusdrobuliak66
matusdrobuliak66 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matusdrobuliak66
Copy link
Contributor

Required for #6441

@odeimaiz odeimaiz enabled auto-merge (squash) November 4, 2024 12:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sanderegg
sanderegg reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit 24445c0 into ITISFoundation:master Nov 4, 2024
50 checks passed
@odeimaiz odeimaiz deleted the fix/service-browser branch November 4, 2024 14:04
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 6, 2024
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @matusdrobuliak66 @ignapas @GitHK @pcrespov @sanderegg