Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite using Derive and new interface #3

Merged
merged 22 commits into from
Dec 16, 2024
Merged

Rewrite using Derive and new interface #3

merged 22 commits into from
Dec 16, 2024

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Dec 6, 2024

This depends on Derive.jl v0.3 (ITensor/Derive.jl#7).

To-do:

  • Make use of ArrayLayouts.DualLayout when taking adjoint of AbstractSparseVector, define Dot/dot to handle inner products (tracking in [ENHANCEMENT] Improve v'v/dot(v, v) implementation to make use of sparsity #8).
  • More constructors for SparseArrayDOK (tracking in [ENHANCEMENT] More SparseArrayDOK constructors #9).
  • Define sparse array concatenation.
  • Get to feature completeness with current SparseArraysBase.jl, including broadcasting, slicing, matrix multiplication, etc.
  • More tests.
  • Rewrite BlockSparseArrays.jl to use Derive.jl and this rewrite of SparseArraysBase.jl.
  • Define slicing by forwarding @interface AbstractSparseInterface Base.getindex(a, I...) to ArrayLayouts.layout_getindex(a, I...) and defining ArrayLayouts.sub_materialize.
  • Rewrite SparseArrayDOK to use Dictionaries.Dictionary instead of Dict.

@mtfishman mtfishman changed the title [WIP] Rewrite using Derive and new interface Rewrite using Derive and new interface Dec 6, 2024
@mtfishman mtfishman marked this pull request as ready for review December 6, 2024 17:25
@mtfishman mtfishman closed this Dec 6, 2024
@mtfishman mtfishman reopened this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@mtfishman mtfishman changed the title Rewrite using Derive and new interface [WIP] Rewrite using Derive and new interface Dec 7, 2024
@mtfishman mtfishman marked this pull request as draft December 7, 2024 00:20
@mtfishman mtfishman changed the title [WIP] Rewrite using Derive and new interface Rewrite using Derive and new interface Dec 16, 2024
@mtfishman mtfishman marked this pull request as ready for review December 16, 2024 01:32
@mtfishman mtfishman merged commit c67b83a into main Dec 16, 2024
10 of 12 checks passed
@mtfishman mtfishman deleted the derive branch December 16, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant