-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite using Derive and new interface #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
changed the title
[WIP] Rewrite using Derive and new interface
Rewrite using Derive and new interface
Dec 6, 2024
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
mtfishman
changed the title
Rewrite using Derive and new interface
[WIP] Rewrite using Derive and new interface
Dec 7, 2024
8 tasks
mtfishman
changed the title
[WIP] Rewrite using Derive and new interface
Rewrite using Derive and new interface
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on Derive.jl v0.3 (ITensor/Derive.jl#7).
To-do:
Make use of(tracking in [ENHANCEMENT] ImproveArrayLayouts.DualLayout
when takingadjoint
ofAbstractSparseVector
, defineDot
/dot
to handle inner productsv'v
/dot(v, v)
implementation to make use of sparsity #8).More constructors for(tracking in [ENHANCEMENT] MoreSparseArrayDOK
SparseArrayDOK
constructors #9).SparseArraysBase.jl
, including broadcasting, slicing, matrix multiplication, etc.BlockSparseArrays.jl
to useDerive.jl
and this rewrite ofSparseArraysBase.jl
.@interface AbstractSparseInterface Base.getindex(a, I...)
toArrayLayouts.layout_getindex(a, I...)
and definingArrayLayouts.sub_materialize
.SparseArrayDOK
to useDictionaries.Dictionary
instead ofDict
.