Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move action-list from icingadb-web #225

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Move action-list from icingadb-web #225

wants to merge 31 commits into from

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Jun 26, 2024 •
edited
Loading

@sukhwinder33445 sukhwinder33445 self-assigned this Jun 26, 2024
@cla-bot cla-bot bot added the cla/signed label Jun 26, 2024
@sukhwinder33445 sukhwinder33445 marked this pull request as draft June 26, 2024 07:20
@sukhwinder33445 sukhwinder33445 force-pushed the move-general-js-files-from-icingadb-web branch from cf14f74 to 91b77ee Compare June 26, 2024 07:28
@raviks789 raviks789 mentioned this pull request Jun 26, 2024
Open
@sukhwinder33445 sukhwinder33445 force-pushed the move-general-js-files-from-icingadb-web branch 2 times, most recently from 93f9582 to c1351b0 Compare July 4, 2024 12:27
@sukhwinder33445 sukhwinder33445 force-pushed the move-general-js-files-from-icingadb-web branch 2 times, most recently from e44e96d to ba3efcc Compare July 19, 2024 09:52
@sukhwinder33445 sukhwinder33445 mentioned this pull request Jul 19, 2024
Draft
@nilmerg nilmerg mentioned this pull request Jul 22, 2024
Merged
@sukhwinder33445 sukhwinder33445 force-pushed the move-general-js-files-from-icingadb-web branch 3 times, most recently from 5d8e9b2 to a8d4219 Compare July 29, 2024 14:32
@sukhwinder33445
Copy link
Contributor Author

sukhwinder33445 commented Jul 29, 2024 •
edited
Loading

Note to myself:

  • Dashboard: Click on an element in list 1, and before it can be loaded, click on an element in list 2 (list 1’s req is cancelled). You will see that list 2 displays the detailed view, but the element in list 1 is still marked as selected.
  • Generalize the data attributes and Icinga dependencies.
  • Key navigation is not required for the dashboard, add a method like disableKeyNavigation(bool).

@sukhwinder33445 sukhwinder33445 force-pushed the move-general-js-files-from-icingadb-web branch 2 times, most recently from ab15275 to 41d14cf Compare July 30, 2024 14:21
@sukhwinder33445
Move action-list from icingadb-web as is
90cfb25
@sukhwinder33445
ActionList: Make it stand alone widget
3044f6a 
Remove icinga dependency
@sukhwinder33445
ActionList: Define const listIdentifier and listItemIdentifier va…
484b3f3 
…riables

Remove/decouple icinga(behavior) based code

Remove/decouple icinga-based code
@sukhwinder33445
ActionList: First search for the action-list in the focussed container
bbae378
@sukhwinder33445
ActionList: remove click selector not(.page-selector)
863aaa3 
it somehow became irrelevant, but must have been important before. But now that we don't want any icingaweb-specific code here, it has to be removed anyway.

it become somehow inrelevent, must be relevant before. But now as we dont want any icingaweb specific code here it must be removed anyway.
@sukhwinder33445
ActionList: OnKeyDown: find next selectable list item based on data-attr
02407ac 
Dont explicitely check for .page-seperator to skip element, skip until an selectable one found or list ends
@sukhwinder33445
ActionList: dont select lastActivated as fallback
e59f55b 
seems unnecessory, deactivating and activating the same element again and again
@sukhwinder33445
ActionList: Remove load-more functionality
d39d704
@sukhwinder33445
ActionList: getDirectionalNext: return only selectable next item or n…
384be57 
…ull if list ends

Make idetifiers const
@sukhwinder33445
ActionList: Simplify code
178ba0f 
use this.list instead of getting list from dom
@sukhwinder33445
ActionList: Load items properly after auto/manual page refresh
ad64597 
Remove unused code
@sukhwinder33445
ActionList: Unbind the keydown event listner properly
eada8d2 
Otherwise, there are several listners that react to the keydown event.
@sukhwinder33445
ActionList: Introduce event selection-start and selection-end
0f6c0f6 
* `load-selection` is renamed to `selection-start`

- `selection-start` is triggered only once, when a new selection starts
- `selection-end` is triggered, when user stop selecting

Remove superfluos params of trigger method
@sukhwinder33445
ActionList: load(): Clear known selection if no detail url given
283a79a
@sukhwinder33445
ActionList: Rename notJquery to $
a6b197b
@sukhwinder33445
ActionList: Introduce the processing property with getter/setter
31f01ad
@sukhwinder33445
Introduce ActionListBehavior
b406507 
This way we avoid adding it to every module that should support actionList functionality.
@sukhwinder33445
Add LoadMore and LoadMoreBehavior
7e85c0d
@sukhwinder33445
ActionList: Remove special handeling for .dashboard
5836d42
@sukhwinder33445
ActionList: Let the ActionList know if it is the primary list
f559fb6 
If the list already contains active items, keypress should navigate to this this.
@sukhwinder33445
ActionListBehavior: Don't return before creating actionLists on #col2
12e6213
@sukhwinder33445
ActionListBehavior: getActionLists(): Return #col1 lists if no param …
afe36af 
…is given
@sukhwinder33445
ActionList: Add class ptoperty isMultiSelectable
f42d406 
Remove superfluous sufix `List` from properties
@sukhwinder33445
ActionList: Add footer count only to primary lists
06d6650
@sukhwinder33445
ActionListBehavior: Set processing to false when the req is cancelled
e9a2cd9
@sukhwinder33445
ActionList: Don't navigate if only a is pressed
4d0e861 
Optimize code
@sukhwinder33445
ActionList: getDirectionNext(): Return list's first/last elem if null…
2befb2a 
… is passed as item
@sukhwinder33445
ActionList: Simplify code
788c210
@sukhwinder33445
ActionList: Use bool isArrowUp param instead event.key
7032956
@sukhwinder33445
ActionList: Take items with css propery display:contents into account
8547467 
For example, the elements of icingadb/hostgroup are `display:contents`, which leads to scrollIntoView() having no effect.
@sukhwinder33445
ActionList: load(): Scroll active item into view
86196fa
@sukhwinder33445 sukhwinder33445 force-pushed the move-general-js-files-from-icingadb-web branch from 693c554 to 86196fa Compare August 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sukhwinder33445 sukhwinder33445

Labels
cla/signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sukhwinder33445