Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move action-list from icingadb-web #225

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Move action-list from icingadb-web #225

wants to merge 31 commits into from

Commits on Aug 5, 2024

  1. Move action-list from icingadb-web as is

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    90cfb25 View commit details
    Browse the repository at this point in the history

  2. ActionList: Make it stand alone widget 

    Remove icinga dependency
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    3044f6a View commit details
    Browse the repository at this point in the history

  3. ActionList: Define const listIdentifier and listItemIdentifier va… 

    …riables

Remove/decouple icinga(behavior) based code

Remove/decouple icinga-based code
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    484b3f3 View commit details
    Browse the repository at this point in the history

  4. ActionList: First search for the action-list in the focussed container

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    bbae378 View commit details
    Browse the repository at this point in the history

  5. ActionList: remove click selector not(.page-selector) 

    it somehow became irrelevant, but must have been important before. But now that we don't want any icingaweb-specific code here, it has to be removed anyway.

it become somehow inrelevent, must be relevant before. But now as we dont want any icingaweb specific code here it must be removed anyway.
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    863aaa3 View commit details
    Browse the repository at this point in the history

  6. ActionList: OnKeyDown: find next selectable list item based on data-attr 

    Dont explicitely check for .page-seperator to skip element, skip until an selectable one found or list ends
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    02407ac View commit details
    Browse the repository at this point in the history

  7. ActionList: dont select lastActivated as fallback 

    seems unnecessory, deactivating and activating the same element again and again
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e59f55b View commit details
    Browse the repository at this point in the history

  8. ActionList: Remove load-more functionality

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    d39d704 View commit details
    Browse the repository at this point in the history

  9. ActionList: getDirectionalNext: return only selectable next item or n… 

    …ull if list ends

Make idetifiers const
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    384be57 View commit details
    Browse the repository at this point in the history

  10. ActionList: Simplify code 

    use this.list instead of getting list from dom
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    178ba0f View commit details
    Browse the repository at this point in the history

  11. ActionList: Load items properly after auto/manual page refresh 

    Remove unused code
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ad64597 View commit details
    Browse the repository at this point in the history

  12. ActionList: Unbind the keydown event listner properly 

    Otherwise, there are several listners that react to the keydown event.
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    eada8d2 View commit details
    Browse the repository at this point in the history

  13. ActionList: Introduce event selection-start and selection-end 

    * `load-selection` is renamed to `selection-start`

- `selection-start` is triggered only once, when a new selection starts
- `selection-end` is triggered, when user stop selecting

Remove superfluos params of trigger method
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    0f6c0f6 View commit details
    Browse the repository at this point in the history

  14. ActionList: load(): Clear known selection if no detail url given

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    283a79a View commit details
    Browse the repository at this point in the history

  15. ActionList: Rename notJquery to $

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    a6b197b View commit details
    Browse the repository at this point in the history

  16. ActionList: Introduce the processing property with getter/setter

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    31f01ad View commit details
    Browse the repository at this point in the history

  17. Introduce ActionListBehavior 

    This way we avoid adding it to every module that should support actionList functionality.
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b406507 View commit details
    Browse the repository at this point in the history

  18. Add LoadMore and LoadMoreBehavior

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    7e85c0d View commit details
    Browse the repository at this point in the history

  19. ActionList: Remove special handeling for .dashboard

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    5836d42 View commit details
    Browse the repository at this point in the history

  20. ActionList: Let the ActionList know if it is the primary list 

    If the list already contains active items, keypress should navigate to this this.
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    f559fb6 View commit details
    Browse the repository at this point in the history

  21. ActionListBehavior: Don't return before creating actionLists on #col2

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    12e6213 View commit details
    Browse the repository at this point in the history

  22. ActionListBehavior: getActionLists(): Return #col1 lists if no param … 

    …is given
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    afe36af View commit details
    Browse the repository at this point in the history

  23. ActionList: Add class ptoperty isMultiSelectable 

    Remove superfluous sufix `List` from properties
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    f42d406 View commit details
    Browse the repository at this point in the history

  24. ActionList: Add footer count only to primary lists

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    06d6650 View commit details
    Browse the repository at this point in the history

  25. ActionListBehavior: Set processing to false when the req is cancelled

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e9a2cd9 View commit details
    Browse the repository at this point in the history

  26. ActionList: Don't navigate if only a is pressed 

    Optimize code
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    4d0e861 View commit details
    Browse the repository at this point in the history

  27. ActionList: getDirectionNext(): Return list's first/last elem if null… 

    … is passed as item
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    2befb2a View commit details
    Browse the repository at this point in the history

  28. ActionList: Simplify code

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    788c210 View commit details
    Browse the repository at this point in the history

  29. ActionList: Use bool isArrowUp param instead event.key

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    7032956 View commit details
    Browse the repository at this point in the history

  30. ActionList: Take items with css propery display:contents into account 

    For example, the elements of icingadb/hostgroup are `display:contents`, which leads to scrollIntoView() having no effect.
    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    8547467 View commit details
    Browse the repository at this point in the history

  31. ActionList: load(): Scroll active item into view

    @sukhwinder33445
    sukhwinder33445 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    86196fa View commit details
    Browse the repository at this point in the history