Skip to content

Commit

Permalink
Merge branch 'release'
Browse files Browse the repository at this point in the history
  • Loading branch information
ImSejin committed Apr 24, 2023
2 parents 6c66fce + 361906c commit 5008e48
Show file tree
Hide file tree
Showing 10 changed files with 241 additions and 145 deletions.
26 changes: 25 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,35 @@
# Table of Contents

- [v3.0.4](#v304): 2023-04-24
- [v3.0.3](#v303): 2023-01-03
- [v3.0.2](#v302): 2022-12-18
- [v3.0.1](#v301): 2022-12-16
- [v3.0.0](#v300): 2022-12-14
- [v2.9.0](#v290): 2022-02-20

# v3.0.4

## Dependencies

- ⬆️ Upgrade: dependency `selenium-java` from `4.6.0` to `4.9.0`
- ⬆️ Upgrade: dependency `lombok` from `1.18.24` to `1.18.26`
- ⬆️ Upgrade: dependency `logback-classic` from `1.4.5` to `1.4.7`
- ⬆️ Upgrade: dependency `slf4j-api` from `2.0.6` to `2.0.7`
- ⬆️ Upgrade: dependency `annotations` from `23.1.0` to `24.0.1`
- ⬆️ Upgrade: dependency `progressbar` from `0.9.4` to `0.9.5`
- ⬆️ Upgrade: dependency `mapstruct-plugin` from `1.5.3.Final` to `1.5.5.Final`
- ⬆️ Upgrade: test dependency `junit5` from `5.9.1` to `5.9.2`
- ⬆️ Upgrade: test dependency `assertj-core` from `3.23.1` to `3.24.2`
- ⬆️ Upgrade: test dependency `mockito-inline` from `4.11.0` to `5.2.0`
- ⬆️ Upgrade: build dependency `maven-compiler-plugin` from `3.10.1` to `3.11.0`
- ⬆️ Upgrade: build dependency `maven-assembly-plugin` from `3.3.0` to `3.5.0`
- ⬆️ Upgrade: build dependency `jacoco-maven-plugin` from `0.8.8` to `0.8.9`

## Troubleshooting

- 🐞 Fix: IOException ... Invalid Status code=403 text=Forbidden
- 🐞 Fix: SessionNotCreatedException ... Could not start a new session. Response code 500

# v3.0.3

## Dependencies
Expand All @@ -20,7 +44,7 @@
## Troubleshooting

- 🐞 Fix: termination of application
- 🐞 Fix: unreproducible issue that failure to get image count
- 🐞 Fix: failure to get image count on locale KOREA

# v3.0.2

Expand Down
18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,22 @@
<p align="center">Downloader for lezhin comics</p>

<p align="center">
<a href="https://sonarcloud.io/summary/new_code?id=ImSejin_lezhin-comics-downloader">
<img alt="Sonarcloud Security Rating" src="https://sonarcloud.io/api/project_badges/measure?project=ImSejin_lezhin-comics-downloader&metric=security_rating"/>
<img alt="GitHub All Releases" src="https://img.shields.io/github/downloads/imsejin/lezhin-comics-downloader/total?style=flat">
<img alt="GitHub Releases" src="https://img.shields.io/github/downloads/imsejin/lezhin-comics-downloader/latest/total?style=flat">
<a href="https://github.com/ImSejin/lezhin-comics-downloader/releases/latest">
<img alt="Latest release" src="https://img.shields.io/github/v/release/ImSejin/lezhin-comics-downloader?color=orange&style=flat">
</a>
<br/>
<a href="https://sonarcloud.io/summary/overall?id=ImSejin_lezhin-comics-downloader">
<img alt="Sonarcloud Quality Gate Status" src="https://sonarcloud.io/api/project_badges/measure?project=ImSejin_lezhin-comics-downloader&metric=alert_status"/>
</a>
<a href="https://sonarcloud.io/summary/new_code?id=ImSejin_lezhin-comics-downloader">
<a href="https://sonarcloud.io/summary/overall?id=ImSejin_lezhin-comics-downloader">
<img alt="Sonarcloud Maintainability Rating" src="https://sonarcloud.io/api/project_badges/measure?project=ImSejin_lezhin-comics-downloader&metric=sqale_rating"/>
</a>
<a href="https://app.codacy.com/gh/ImSejin/lezhin-comics-downloader/dashboard">
<img alt="Codacy grade" src="https://img.shields.io/codacy/grade/1a2400c31a8346ddbf108fb3ac78f481?style=flat&logo=codacy">
</a>
<img alt="jdk11" src="https://img.shields.io/badge/jdk-11-orange?style=flat">
<br/>
<img alt="GitHub All Releases" src="https://img.shields.io/github/downloads/imsejin/lezhin-comics-downloader/total?style=flat">
<img alt="GitHub Releases" src="https://img.shields.io/github/downloads/imsejin/lezhin-comics-downloader/latest/total?style=flat">
<a href="https://github.com/ImSejin/lezhin-comics-downloader/releases/latest">
<img alt="Latest release" src="https://img.shields.io/github/v/release/ImSejin/lezhin-comics-downloader?color=orange&style=flat">
</a>
</p>

# Preview
Expand Down
35 changes: 20 additions & 15 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>io.github.imsejin</groupId>
<artifactId>lezhin-comics-downloader</artifactId>
<version>3.0.3</version>
<version>3.0.4</version>
<packaging>jar</packaging>

<name>Lezhin Comics Downloader</name>
Expand Down Expand Up @@ -43,21 +43,21 @@
<!-- Dependency versions -->
<common-utils.version>0.14.0</common-utils.version>
<commons-cli.version>1.5.0</commons-cli.version>
<progressbar.version>0.9.4</progressbar.version>
<progressbar.version>0.9.5</progressbar.version>
<reftrofit.version>2.9.0</reftrofit.version>
<selenium.version>4.6.0</selenium.version>
<selenium.version>4.9.0</selenium.version>
<reflections.version>0.10.2</reflections.version>
<lombok.version>1.18.24</lombok.version>
<mapstruct.version>1.5.3.Final</mapstruct.version>
<jetbrains-annotations.version>23.1.0</jetbrains-annotations.version>
<logback-classic.version>1.4.5</logback-classic.version>
<slf4j-api.version>2.0.6</slf4j-api.version>
<lombok.version>1.18.26</lombok.version>
<mapstruct.version>1.5.5.Final</mapstruct.version>
<jetbrains-annotations.version>24.0.1</jetbrains-annotations.version>
<logback-classic.version>1.4.7</logback-classic.version>
<slf4j-api.version>2.0.7</slf4j-api.version>

<!-- Test dependency versions -->
<junit5.version>5.9.1</junit5.version>
<assertj.version>3.23.1</assertj.version>
<junit5.version>5.9.2</junit5.version>
<assertj.version>3.24.2</assertj.version>
<spock.version>2.3-groovy-4.0</spock.version>
<mockito.version>4.11.0</mockito.version>
<mockito.version>5.2.0</mockito.version>
</properties>

<!-- Enables to build on development environment -->
Expand Down Expand Up @@ -133,6 +133,11 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-http-jdk-client</artifactId>
<version>${selenium.version}</version>
</dependency>

<!-- Reflections -->
<dependency>
Expand Down Expand Up @@ -271,7 +276,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.10.1</version>
<version>3.11.0</version>
<configuration>
<source>${java.version}</source>
<target>${java.version}</target>
Expand Down Expand Up @@ -306,7 +311,7 @@
<testFailureIgnore>false</testFailureIgnore>
<!--
Only required if names of test classes don't match default Surefire patterns('*Test').
By default only files ending in 'Test' will be included,
By default, only files ending with 'Test' will be included,
so also include support for Spock style naming convention.
Oddly enough for Groovy files, '*Spec.groovy' does not work, but '*Spec.java'.
Expand Down Expand Up @@ -352,7 +357,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
<version>3.4.2</version>
<version>3.5.0</version>
<executions>
<execution>
<id>create-jar</id>
Expand Down Expand Up @@ -387,7 +392,7 @@
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>0.8.8</version>
<version>0.8.9</version>
<executions>
<execution>
<goals>
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/io/github/imsejin/dl/lezhin/Application.java
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ public static void main(String[] args) {
Object attribute = processor.process(context);
context.add(attribute);
}
} catch (Exception e) {
Loggers.getLogger().error("Failed to perform a process", e);
} catch (Throwable t) {
Loggers.getLogger().error("Failed to perform a process", t);
} finally {
WebBrowser.quitIfInitialized();
}
Expand Down
112 changes: 112 additions & 0 deletions src/main/java/io/github/imsejin/dl/lezhin/browser/ChromeOption.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
package io.github.imsejin.dl.lezhin.browser;

import lombok.Getter;
import lombok.RequiredArgsConstructor;

import java.util.Arrays;
import java.util.List;

import static java.util.stream.Collectors.toList;

/**
* @since 2.6.2
*/
@Getter
@RequiredArgsConstructor
public enum ChromeOption {

/**
* Opens browser on private mode.
*/
INCOGNITO("--incognito"),

/**
* Runs browser using CLI.
*/
HEADLESS("--headless=new"),

/**
* Bypasses OS security model.
*
* @since 2.8.2
*/
NO_SANDBOX("--no-sandbox"),

/**
* Disables GPU computation (applicable to Windows OS only).
*
* @since 2.8.2
*/
DISABLE_GPU("--disable-gpu"),

/**
* Ignores certificate errors.
*/
IGNORE_CERTIFICATE_ERRORS("--ignore-certificate-errors"),

/**
* Disables to check if Google Chrome is default browser on your device.
*
* @since 2.8.2
*/
NO_DEFAULT_BROWSER_CHECK("--no-default-browser-check"),

/**
* Disables popup blocking.
*/
DISABLE_POPUP_BLOCKING("--disable-popup-blocking"),

/**
* Disables installed extensions(plugins) of Google Chrome.
*
* @since 2.8.2
*/
DISABLE_EXTENSIONS("--disable-extensions"),

/**
* Disables default web apps on Google Chrome’s new tab page
* <p>
* Chrome Web Store, Google Drive, Gmail, YouTube, Google Search, etc.
*/
DISABLE_DEFAULT_APPS("--disable-default-apps"),

/**
* Disables Google translate feature.
*
* @since 2.8.2
*/
DISABLE_TRANSLATE("--disable-translate"),

/**
* Disables detection for client side phishing.
*
* @since 2.8.2
*/
DISABLE_CLIENT_SIDE_PHISHING_DETECTION("--disable-client-side-phishing-detection"),

/**
* Overcomes limited resource problems.
*
* @since 2.8.2
*/
DISABLE_DEV_SHM_USAGE("--disable-dev-shm-usage"),

/**
* Allows all remote origins.
*
* @since 3.0.4
*/
REMOTE_ALLOW_ALL_ORIGINS("--remote-allow-origins=*"),

/**
* Opens browser in maximized mode.
*/
START_MAXIMIZED("--start-maximized");

private final String argument;

public static List<String> getArguments() {
return Arrays.stream(values()).map(it -> it.argument).collect(toList());
}

}
Loading

0 comments on commit 5008e48

Please sign in to comment.