Fix Eq, Show for Proposal type #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
force-pushed
the
mgalazyn/fix/fix-eq-show-proposal-type
branch
from
dc20f0a
to
7b922f9
Compare
carbolymer
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy and
disassembler
as code owners
Jimbo4350
reviewed
Jul 12, 2023
| @@ -3598,12 +3598,16 @@ convReferenceInputs txInsReference = | |||
| TxInsReferenceNone -> mempty | |||
| TxInsReference _ refTxins -> Set.fromList $ map toShelleyTxIn refTxins | |||
|
|
|||
| convGovActions :: ShelleyBasedEra era -> TxGovernanceActions era -> Seq.StrictSeq (Gov.ProposalProcedure (ShelleyLedgerEra era)) | |||
| convGovActions :: forall era. Ledger.EraCrypto (ShelleyLedgerEra era) ~ StandardCrypto => ShelleyBasedEra era -> TxGovernanceActions era -> Seq.StrictSeq (Gov.ProposalProcedure (ShelleyLedgerEra era)) | |||
There was a problem hiding this comment.
We can satisfy this constraint within the function (and save the caller from having to satisfy it) via the following:
(StakeKeyHash $ obtainEraCryptoConstraints sbe pProcReturnAddr)
There was a problem hiding this comment.
I think I can simplify this even further without needing list comprehension at all.
| deriving instance (Shelley.EraPParams (ShelleyLedgerEra era)) => Eq (Proposal era) | ||
| instance IsShelleyBasedEra era => Show (Proposal era) where | ||
| show (Proposal pp) = do | ||
| let ppStr = withShelleyBasedEraConstraintsForLedger (shelleyBasedEra @era) $ show pp |
There was a problem hiding this comment.
Good work however what we really should be doing is asking the ledger team to provide a show instance for us. Can you propagate these changes to cardano-cli to see how what the changes will look like?
There was a problem hiding this comment.
carbolymer
force-pushed
the
mgalazyn/fix/fix-eq-show-proposal-type
branch
2 times, most recently
from
d3a2da5
to
27f66b9
Compare
This was referenced Jul 12, 2023
carbolymer
force-pushed
the
mgalazyn/fix/fix-eq-show-proposal-type
branch
from
27f66b9
to
e2fef97
Compare
Jimbo4350
approved these changes
Jul 12, 2023
newhoggy
added a commit
that referenced
this pull request
Mar 11, 2024
…no-api-8.10.2.0 Update to `cardano-api-8.10.2.0`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Fixing Conway TODOs.
Checklist
.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.