Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose querySPOStakeDistribution query #598

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

palas
Copy link
Contributor

@palas palas commented Jul 27, 2024

Changelog

- description: |
    Exposed `querySPOStakeDistribution` query
  type:
  - feature        # introduces a new feature

Context

We want to provide a governance query for stake distribution of stake pools to the cardano-cli (see this issue), so we need to be able to do the query through the cardano-api. This PR does just that, it exposes the new query.

Associated PRs:

How to trust this PR

I think the fact that it compiles is pretty telling. But maybe ensure that there is nothing missing to export, that it doesn't have any typos or so. And it is is quite based on the similar query for drepss, so it is not difficult that I failed to change replace some of the DRep mentions, stay alert for those (I did double-check myself though).

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Be sure to test this on cardano-node before merging please.

@palas palas added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 74cb3b8 Jul 31, 2024
26 checks passed
@palas palas deleted the query-spo-stake-distr-api branch July 31, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] - Provide governance query for stake distribution
3 participants